Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-20 Thread Jakub Kicinski
On Tue, 19 Feb 2019 21:01:29 -0800, Stanislav Fomichev wrote: > On 02/19, Jakub Kicinski wrote: > > On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > > > +#include "bpf_load.h" > > > > nit: please use libbpf > My suggestion was to just use bpftool, no need for another helper in the > sampl

Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-19 Thread Stanislav Fomichev
On 02/19, Jakub Kicinski wrote: > On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > > +#include "bpf_load.h" > > nit: please use libbpf My suggestion was to just use bpftool, no need for another helper in the samples/ directory. WDYT?

Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > +#include "bpf_load.h" nit: please use libbpf

[PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-18 Thread brakmo
The program load_cg_skb can be used to load BPF_PROG_TYPE_CGROUP_SKB type bpf_prog which currently can be attached to the ingress and egress patch. It can also be used to detach the bpf_prog. Examples: load_cg_skb [-i] Load and attaches a cg skb program to the specified cgroup. If "-i"