Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-27 Thread Jesper Dangaard Brouer
On Wed, 27 May 2020 17:01:10 +0200 Toke Høiland-Jørgensen wrote: > David Ahern writes: > > > On 5/27/20 4:02 AM, Toke Høiland-Jørgensen wrote: > >> David Ahern writes: > >> > >>> Support SEC("xdp_dm*") as a short cut for loading the program with > >>> type BPF_PROG_TYPE_XDP and expected a

Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 5/27/20 4:02 AM, Toke Høiland-Jørgensen wrote: >> David Ahern writes: >> >>> Support SEC("xdp_dm*") as a short cut for loading the program with >>> type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP. >> >> You're not using this in the selftest; shouldn't yo

Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-27 Thread David Ahern
On 5/27/20 4:02 AM, Toke Høiland-Jørgensen wrote: > David Ahern writes: > >> Support SEC("xdp_dm*") as a short cut for loading the program with >> type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP. > > You're not using this in the selftest; shouldn't you be? Also, the > prefix shoul

Re: [PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-27 Thread Toke Høiland-Jørgensen
David Ahern writes: > Support SEC("xdp_dm*") as a short cut for loading the program with > type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP. You're not using this in the selftest; shouldn't you be? Also, the prefix should be libbpf: not bpftool:, no? -Toke

[PATCH bpf-next 4/5] bpftool: Add SEC name for xdp programs attached to device map

2020-05-26 Thread David Ahern
Support SEC("xdp_dm*") as a short cut for loading the program with type BPF_PROG_TYPE_XDP and expected attach type BPF_XDP_DEVMAP. Signed-off-by: David Ahern --- tools/lib/bpf/libbpf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index fa0