Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-17 Thread Andrii Nakryiko
On Mon, Jun 17, 2019 at 11:07 AM Song Liu wrote: > > > > > On Jun 17, 2019, at 10:24 AM, Andrii Nakryiko > > wrote: > > > > On Sat, Jun 15, 2019 at 1:26 PM Song Liu wrote: > >> > >> On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > >>> > >>> As a preparation for adding BTF-based BPF map

Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-17 Thread Song Liu
> On Jun 17, 2019, at 10:24 AM, Andrii Nakryiko > wrote: > > On Sat, Jun 15, 2019 at 1:26 PM Song Liu wrote: >> >> On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: >>> >>> As a preparation for adding BTF-based BPF map loading, extract .BTF and >>> .BTF.ext loading logic. Also simpli

Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-17 Thread Andrii Nakryiko
On Sat, Jun 15, 2019 at 1:28 PM Song Liu wrote: > > On Sat, Jun 15, 2019 at 1:25 PM Song Liu wrote: > > > > On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > > > > > > As a preparation for adding BTF-based BPF map loading, extract .BTF and > > > .BTF.ext loading logic. Also simplify error

Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-17 Thread Andrii Nakryiko
On Sat, Jun 15, 2019 at 1:26 PM Song Liu wrote: > > On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > > > > As a preparation for adding BTF-based BPF map loading, extract .BTF and > > .BTF.ext loading logic. Also simplify error handling in > > bpf_object__elf_collect() by returning early,

Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-15 Thread Song Liu
On Sat, Jun 15, 2019 at 1:25 PM Song Liu wrote: > > On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > > > > As a preparation for adding BTF-based BPF map loading, extract .BTF and > > .BTF.ext loading logic. Also simplify error handling in > > bpf_object__elf_collect() by returning early,

Re: [PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-15 Thread Song Liu
On Mon, Jun 10, 2019 at 9:49 PM Andrii Nakryiko wrote: > > As a preparation for adding BTF-based BPF map loading, extract .BTF and > .BTF.ext loading logic. Also simplify error handling in > bpf_object__elf_collect() by returning early, as there is no common > clean up to be done. > > Signed-off-b

[PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-10 Thread Andrii Nakryiko
As a preparation for adding BTF-based BPF map loading, extract .BTF and .BTF.ext loading logic. Also simplify error handling in bpf_object__elf_collect() by returning early, as there is no common clean up to be done. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 137 +++

[RFC PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-06-10 Thread Andrii Nakryiko
As a preparation for adding BTF-based BPF map loading, extract .BTF and .BTF.ext loading logic. Also simplify error handling in bpf_object__elf_collect() by returning early, as there is no common clean up to be done. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 137 +++

[RFC PATCH bpf-next 2/8] libbpf: extract BTF loading and simplify ELF parsing logic

2019-05-31 Thread Andrii Nakryiko
As a preparation for adding BTF-based BPF map loading, extract .BTF and .BTF.ext loading logic. Also simplify error handling in bpf_object__elf_collect() by returning early, as there is no common clean up to be done. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 137 +++