Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-15 Thread Andrii Nakryiko
On Thu, Aug 15, 2019 at 10:16 PM Alexei Starovoitov wrote: > > On Wed, Aug 14, 2019 at 1:01 PM Andrii Nakryiko > wrote: > > > > > > Let me know if you see a value in highlighting test vs subtest skip. > > > > > > Other related question is: should we do verbose output in case > > > of a skip? Righ

Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-15 Thread Alexei Starovoitov
On Wed, Aug 14, 2019 at 1:01 PM Andrii Nakryiko wrote: > > > > Let me know if you see a value in highlighting test vs subtest skip. > > > > Other related question is: should we do verbose output in case > > of a skip? Right now we don't do it. > > It might be useful, I guess, especially if it's no

Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-14 Thread Andrii Nakryiko
On Wed, Aug 14, 2019 at 12:53 PM Stanislav Fomichev wrote: > > On 08/14, Andrii Nakryiko wrote: > > On Wed, Aug 14, 2019 at 12:22 PM Andrii Nakryiko > > wrote: > > > > > > On Wed, Aug 14, 2019 at 9:48 AM Stanislav Fomichev > > > wrote: > > > > > > > > Export test__skip() to indicate skipped tes

Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-14 Thread Stanislav Fomichev
On 08/14, Andrii Nakryiko wrote: > On Wed, Aug 14, 2019 at 12:22 PM Andrii Nakryiko > wrote: > > > > On Wed, Aug 14, 2019 at 9:48 AM Stanislav Fomichev wrote: > > > > > > Export test__skip() to indicate skipped tests and use it in > > > test_send_signal_nmi(). > > > > > > Cc: Andrii Nakryiko > >

Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-14 Thread Andrii Nakryiko
On Wed, Aug 14, 2019 at 12:22 PM Andrii Nakryiko wrote: > > On Wed, Aug 14, 2019 at 9:48 AM Stanislav Fomichev wrote: > > > > Export test__skip() to indicate skipped tests and use it in > > test_send_signal_nmi(). > > > > Cc: Andrii Nakryiko > > Signed-off-by: Stanislav Fomichev > > --- > > For

Re: [PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-14 Thread Andrii Nakryiko
On Wed, Aug 14, 2019 at 9:48 AM Stanislav Fomichev wrote: > > Export test__skip() to indicate skipped tests and use it in > test_send_signal_nmi(). > > Cc: Andrii Nakryiko > Signed-off-by: Stanislav Fomichev > --- For completeness, we should probably also support test__skip_subtest() eventually

[PATCH bpf-next 2/4] selftests/bpf: test_progs: test__skip

2019-08-14 Thread Stanislav Fomichev
Export test__skip() to indicate skipped tests and use it in test_send_signal_nmi(). Cc: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/prog_tests/send_signal.c | 1 + tools/testing/selftests/bpf/test_progs.c | 9 +++-- tools/testing/selftests/b