RE: [PATCH bpf-next 2/4] selftests/bpf: expose debug arg to shell script for xsk tests

2021-02-22 Thread Loftus, Ciara
> > On Wed, Feb 17, 2021 at 5:36 PM Ciara Loftus > wrote: > > > > Launching xdpxceiver with -D enables debug mode. Make it possible > > Would be clearer if the option was the same both in the shell and in > the xdpreceiver app, so please pick -d or -D and stick with it. And > how about calling t

Re: [PATCH bpf-next 2/4] selftests/bpf: expose debug arg to shell script for xsk tests

2021-02-19 Thread Magnus Karlsson
On Wed, Feb 17, 2021 at 5:36 PM Ciara Loftus wrote: > > Launching xdpxceiver with -D enables debug mode. Make it possible Would be clearer if the option was the same both in the shell and in the xdpreceiver app, so please pick -d or -D and stick with it. And how about calling the mode "dump packe

[PATCH bpf-next 2/4] selftests/bpf: expose debug arg to shell script for xsk tests

2021-02-17 Thread Ciara Loftus
Launching xdpxceiver with -D enables debug mode. Make it possible to pass this flag to the app via the test_xsk.sh shell script like so: ./test_xsk.sh -d Signed-off-by: Ciara Loftus --- tools/testing/selftests/bpf/test_xsk.sh| 7 ++- tools/testing/selftests/bpf/xsk_prereqs.sh | 3 ++- 2