Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

2021-02-19 Thread Björn Töpel
On 2021-02-19 18:10, Toke Høiland-Jørgensen wrote: + case XDP_REDIR_DEV_MAP: { struct bpf_dtab_netdev *dst = fwd; I thought the braces around the case body looked a bit odd. I guess that's to get a local scope for the dst var (and xs var below), right? This is basically a c

Re: [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

2021-02-19 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > From: Björn Töpel > > The XDP_REDIRECT implementations for maps and non-maps are fairly > similar, but obviously need to take different code paths depending on > if the target is using a map or not. Today, the redirect targets for > XDP either uses a map, or is based on ifi

[PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions

2021-02-19 Thread Björn Töpel
From: Björn Töpel The XDP_REDIRECT implementations for maps and non-maps are fairly similar, but obviously need to take different code paths depending on if the target is using a map or not. Today, the redirect targets for XDP either uses a map, or is based on ifindex. Here, an explicit redirect