Re: [PATCH bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-10-30 Thread Song Liu
On Fri, Oct 30, 2020 at 11:45 AM Andrii Nakryiko wrote: > [...] > > > @@ -6775,10 +6774,15 @@ static void do_test_dedup(unsigned int test_num) > > > err = -1; > > > goto done; > > > } > > > - if (CHECK(memcmp((void *)tes

Re: [PATCH bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-10-30 Thread Andrii Nakryiko
On Fri, Oct 30, 2020 at 9:43 AM Song Liu wrote: > > On Thu, Oct 29, 2020 at 1:40 AM Andrii Nakryiko wrote: > > > > Remove the requirement of a strictly exact string section contents. This > > used > > to be true when string deduplication was done through sorting, but with > > string > > dedup d

Re: [PATCH bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-10-30 Thread Song Liu
On Thu, Oct 29, 2020 at 1:40 AM Andrii Nakryiko wrote: > > Remove the requirement of a strictly exact string section contents. This used > to be true when string deduplication was done through sorting, but with string > dedup done through hash table, it's no longer true. So relax test harness to >

[PATCH bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-10-28 Thread Andrii Nakryiko
Remove the requirement of a strictly exact string section contents. This used to be true when string deduplication was done through sorting, but with string dedup done through hash table, it's no longer true. So relax test harness to relax strings checks and, consequently, type checks, which now do