Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-09-03 Thread Alexei Starovoitov
On Tue, Sep 03, 2019 at 04:07:17PM -0700, Brian Vazquez wrote: > > We could also modify get_next_key behaviour _only_ when it's called > from a dumping function in which case we do know that we want to move > forward not backwards (basically if prev_key is not found, then > retrieve the first key

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-09-03 Thread Yonghong Song
On 9/3/19 3:30 PM, Stanislav Fomichev wrote: > On 09/03, Alexei Starovoitov wrote: >> On Fri, Aug 30, 2019 at 02:18:09PM -0700, Stanislav Fomichev wrote: > > I personally like Jakub's/Quentin's proposal more. So if I get to choose > between this series and Jakub's filter+dump in BPF,

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-09-03 Thread Brian Vazquez
On Tue, Sep 3, 2019 at 3:30 PM Stanislav Fomichev wrote: > > On 09/03, Alexei Starovoitov wrote: > > On Fri, Aug 30, 2019 at 02:18:09PM -0700, Stanislav Fomichev wrote: > > > > > > > > > > I personally like Jakub's/Quentin's proposal more. So if I get to > > > > > choose > > > > > between this se

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-09-03 Thread Stanislav Fomichev
On 09/03, Alexei Starovoitov wrote: > On Fri, Aug 30, 2019 at 02:18:09PM -0700, Stanislav Fomichev wrote: > > > > > > > > I personally like Jakub's/Quentin's proposal more. So if I get to choose > > > > between this series and Jakub's filter+dump in BPF, I'd pick filter+dump > > > > (pending per-c

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-09-03 Thread Alexei Starovoitov
On Fri, Aug 30, 2019 at 02:18:09PM -0700, Stanislav Fomichev wrote: > > > > > > I personally like Jakub's/Quentin's proposal more. So if I get to choose > > > between this series and Jakub's filter+dump in BPF, I'd pick filter+dump > > > (pending per-cpu issue which we actually care about). > > >

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Yonghong Song
On 8/30/19 2:35 PM, Jakub Kicinski wrote: > On Fri, 30 Aug 2019 07:25:54 +, Yonghong Song wrote: >> On 8/29/19 11:39 AM, Jakub Kicinski wrote: >>> On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one map en

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Yonghong Song
On 8/30/19 2:10 PM, Jakub Kicinski wrote: > On Fri, 30 Aug 2019 20:55:33 +, Yonghong Song wrote: >>> I guess you can hold off this series a bit and discuss it at LPC, >>> you have a talk dedicated to that :-) (and afaiu, you are all going) >> >> Absolutely. We will have a discussion on map ba

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Jakub Kicinski
On Fri, 30 Aug 2019 07:25:54 +, Yonghong Song wrote: > On 8/29/19 11:39 AM, Jakub Kicinski wrote: > > On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: > >> Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > >> map entries per syscall. > >> > >> https://lore

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Stanislav Fomichev
On 08/30, Yonghong Song wrote: > > > On 8/30/19 1:15 PM, Stanislav Fomichev wrote: > > On 08/29, Jakub Kicinski wrote: > >> On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote: > We need a per-map implementation of the exec side, but roughly maps > would do: > > L

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Jakub Kicinski
On Fri, 30 Aug 2019 20:55:33 +, Yonghong Song wrote: > > I guess you can hold off this series a bit and discuss it at LPC, > > you have a talk dedicated to that :-) (and afaiu, you are all going) > > Absolutely. We will have a discussion on map batching and I signed > on with that :-) FWIW

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Yonghong Song
On 8/30/19 1:15 PM, Stanislav Fomichev wrote: > On 08/29, Jakub Kicinski wrote: >> On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote: We need a per-map implementation of the exec side, but roughly maps would do: LIST_HEAD(deleted); for entry i

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Stanislav Fomichev
On 08/29, Jakub Kicinski wrote: > On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote: > > > We need a per-map implementation of the exec side, but roughly maps > > > would do: > > > > > > LIST_HEAD(deleted); > > > > > > for entry in map { > > > struct map_op_ctx

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-30 Thread Yonghong Song
On 8/29/19 11:39 AM, Jakub Kicinski wrote: > On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: >> Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one >> map entries per syscall. >> >> https://lore.kernel.org/bpf/cabcgpau3xxx6cmmxd+1knapivtc2jlbhysdxw-0e9bqel0q...@m

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-29 Thread Jakub Kicinski
On Thu, 29 Aug 2019 16:13:59 -0700, Brian Vazquez wrote: > > We need a per-map implementation of the exec side, but roughly maps > > would do: > > > > LIST_HEAD(deleted); > > > > for entry in map { > > struct map_op_ctx { > > .key= entry->

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-29 Thread Brian Vazquez
On Thu, Aug 29, 2019 at 11:40 AM Jakub Kicinski wrote: > > On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: > > Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > > map entries per syscall. > > > > https://lore.kernel.org/bpf/cabcgpau3xxx6cmmxd+1knapivtc2jlbhysdx

Re: [PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-29 Thread Jakub Kicinski
On Wed, 28 Aug 2019 23:45:02 -0700, Yonghong Song wrote: > Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one > map entries per syscall. > > https://lore.kernel.org/bpf/cabcgpau3xxx6cmmxd+1knapivtc2jlbhysdxw-0e9bqel0q...@mail.gmail.com/T/#t > > During discussion, we found

[PATCH bpf-next 00/13] bpf: adding map batch processing support

2019-08-28 Thread Yonghong Song
Brian Vazquez has proposed BPF_MAP_DUMP command to look up more than one map entries per syscall. https://lore.kernel.org/bpf/cabcgpau3xxx6cmmxd+1knapivtc2jlbhysdxw-0e9bqel0q...@mail.gmail.com/T/#t During discussion, we found more use cases can be supported in a similar map operation batching f