RE: [PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-08 Thread David Laight
From: Andrii Nakryiko > Sent: 07 February 2019 17:50 > > Few files in libbpf are using bzero() function (defined in strings.h header), > but > don't include corresponding header. When libbpf is added as a dependency to > pahole, > this undeterministically causes warnings on some machines: > > b

Re: [PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-07 Thread Andrii Nakryiko
On Thu, Feb 7, 2019 at 11:21 AM Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 07, 2019 at 09:50:27AM -0800, Andrii Nakryiko escreveu: > > Few files in libbpf are using bzero() function (defined in strings.h > > header), but > > don't include corresponding header. When libbpf is added as a depen

Re: [PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-07 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 07, 2019 at 09:50:27AM -0800, Andrii Nakryiko escreveu: > Few files in libbpf are using bzero() function (defined in strings.h header), > but > don't include corresponding header. When libbpf is added as a dependency to > pahole, > this undeterministically causes warnings on some mach

Re: [PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-07 Thread Alexei Starovoitov
On Thu, Feb 07, 2019 at 09:50:27AM -0800, Andrii Nakryiko wrote: > Few files in libbpf are using bzero() function (defined in strings.h header), > but > don't include corresponding header. When libbpf is added as a dependency to > pahole, > this undeterministically causes warnings on some machine

Re: [PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-07 Thread Andrii Nakryiko
cc Arnaldo On Thu, Feb 7, 2019 at 9:52 AM Andrii Nakryiko wrote: > > Few files in libbpf are using bzero() function (defined in strings.h header), > but > don't include corresponding header. When libbpf is added as a dependency to > pahole, > this undeterministically causes warnings on some mac

[PATCH bpf-next] tools/bpf: add missing strings.h include

2019-02-07 Thread Andrii Nakryiko
Few files in libbpf are using bzero() function (defined in strings.h header), but don't include corresponding header. When libbpf is added as a dependency to pahole, this undeterministically causes warnings on some machines: bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimpl