Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 6:57 AM Daniel Borkmann wrote: > > On 07/12/2019 09:53 AM, Krzesimir Nowak wrote: > > On Thu, Jul 11, 2019 at 4:43 PM Andrii Nakryiko > > wrote: > >> > >> On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak > >> wrote: > >>> > >>> On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakry

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 09:53 AM, Krzesimir Nowak wrote: > On Thu, Jul 11, 2019 at 4:43 PM Andrii Nakryiko > wrote: >> >> On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak wrote: >>> >>> On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakryiko wrote: test_verifier tests can specify single- and multi-runs t

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Krzesimir Nowak
On Thu, Jul 11, 2019 at 4:43 PM Andrii Nakryiko wrote: > > On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak wrote: > > > > On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakryiko wrote: > > > > > > test_verifier tests can specify single- and multi-runs tests. Internally > > > logic of handling them is du

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-11 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak wrote: > > On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakryiko wrote: > > > > test_verifier tests can specify single- and multi-runs tests. Internally > > logic of handling them is duplicated. Get rid of it by making single run > > retval specification

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-11 Thread Krzesimir Nowak
On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakryiko wrote: > > test_verifier tests can specify single- and multi-runs tests. Internally > logic of handling them is duplicated. Get rid of it by making single run > retval specification to be a first retvals spec. > > Cc: Krzesimir Nowak > Signed-off-by

[PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-10 Thread Andrii Nakryiko
test_verifier tests can specify single- and multi-runs tests. Internally logic of handling them is duplicated. Get rid of it by making single run retval specification to be a first retvals spec. Cc: Krzesimir Nowak Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_verifier.c |