Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-15 Thread Daniel Borkmann
On 10/15/20 7:50 AM, Song Liu wrote: On Oct 14, 2020, at 9:29 PM, Alexei Starovoitov wrote: On Tue, Oct 13, 2020 at 09:36:38PM -0700, Song Liu wrote: Fix the following error when compiling selftests/bpf progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of sy

Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-14 Thread Song Liu
> On Oct 14, 2020, at 9:29 PM, Alexei Starovoitov > wrote: > > On Tue, Oct 13, 2020 at 09:36:38PM -0700, Song Liu wrote: >> Fix the following error when compiling selftests/bpf >> >> progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as >> different kind of symbol >> >> pids

Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-14 Thread Alexei Starovoitov
On Tue, Oct 13, 2020 at 09:36:38PM -0700, Song Liu wrote: > Fix the following error when compiling selftests/bpf > > progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as > different kind of symbol > > pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the > error

Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-14 Thread John Fastabend
Song Liu wrote: > > > > On Oct 13, 2020, at 9:36 PM, Song Liu wrote: > > > > Fix the following error when compiling selftests/bpf > > > > progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as > > different kind of symbol > > > > pids_cgrp_id is used in cgroup code, and include

Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-14 Thread Song Liu
> On Oct 13, 2020, at 9:36 PM, Song Liu wrote: > > Fix the following error when compiling selftests/bpf > > progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as > different kind of symbol > > pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the > error by

[PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-13 Thread Song Liu
Fix the following error when compiling selftests/bpf progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of symbol pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the error by renaming pids_cgrp_id as pids_cgroup_id. Fixes: 03d4d13fab3f ("self