Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-11-07 Thread Daniel Borkmann
On 11/07/2018 01:28 PM, Quentin Monnet wrote: > libbpf is now able to load successfully test_l4lb_noinline.o and > samples/bpf/tracex3_kern.o. > > For the test_l4lb_noinline, uncomment related tests from test_libbpf.c > and remove the associated "TODO". > > For tracex3_kern.o, instead of loading

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-11-07 Thread Jesper Dangaard Brouer
On Wed, 7 Nov 2018 12:28:45 + Quentin Monnet wrote: > libbpf is now able to load successfully test_l4lb_noinline.o and > samples/bpf/tracex3_kern.o. > > For the test_l4lb_noinline, uncomment related tests from test_libbpf.c > and remove the associated "TODO". > > For tracex3_kern.o, instea

[PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-11-07 Thread Quentin Monnet
libbpf is now able to load successfully test_l4lb_noinline.o and samples/bpf/tracex3_kern.o. For the test_l4lb_noinline, uncomment related tests from test_libbpf.c and remove the associated "TODO". For tracex3_kern.o, instead of loading a program from samples/bpf/ that might not have been compile

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-22 Thread Jesper Dangaard Brouer
On Mon, 22 Oct 2018 11:00:27 +0100 Quentin Monnet wrote: > 2018-10-21 23:04 UTC+0200 ~ Jesper Dangaard Brouer > > On Sun, 21 Oct 2018 16:37:08 +0100 > > Quentin Monnet wrote: > > > >> 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > >>> On Sat, 20 Oct 2018 23:00:24 +0100 > >>> Quentin

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-22 Thread Quentin Monnet
2018-10-21 23:04 UTC+0200 ~ Jesper Dangaard Brouer > On Sun, 21 Oct 2018 16:37:08 +0100 > Quentin Monnet wrote: > >> 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer >>> On Sat, 20 Oct 2018 23:00:24 +0100 >>> Quentin Monnet wrote: >>> >> >> [...] >> --- a/tools/testing/selftests/bpf/

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Jesper Dangaard Brouer
On Sun, 21 Oct 2018 16:37:08 +0100 Quentin Monnet wrote: > 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > > On Sat, 20 Oct 2018 23:00:24 +0100 > > Quentin Monnet wrote: > > > > [...] > > >> --- a/tools/testing/selftests/bpf/test_libbpf.sh > >> +++ b/tools/testing/selftests/bpf/test_l

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Quentin Monnet
2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > On Sat, 20 Oct 2018 23:00:24 +0100 > Quentin Monnet wrote: > [...] >> --- a/tools/testing/selftests/bpf/test_libbpf.sh >> +++ b/tools/testing/selftests/bpf/test_libbpf.sh >> @@ -33,17 +33,11 @@ trap exit_handler 0 2 3 6 9 >> >> libbpf_o

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-21 Thread Jesper Dangaard Brouer
On Sat, 20 Oct 2018 23:00:24 +0100 Quentin Monnet wrote: > libbpf is now able to load successfully test_l4lb_noinline.o and > samples/bpf/tracex3_kern.o, so we can uncomment related tests from > test_libbpf.c and remove the associated "TODO"s. Thanks for working on this, comments below. > It is

[PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-20 Thread Quentin Monnet
libbpf is now able to load successfully test_l4lb_noinline.o and samples/bpf/tracex3_kern.o, so we can uncomment related tests from test_libbpf.c and remove the associated "TODO"s. It is also trivial to fix test_xdp_noinline.o so that it provides a version and can be loaded. Fix it and uncomment t