Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-14 Thread Andrii Nakryiko
On Wed, Aug 14, 2019 at 12:12 AM Andrey Ignatov wrote: > > Andrii Nakryiko [Tue, 2019-08-13 21:46 -0700]: > > On Tue, Aug 13, 2019 at 5:28 PM Andrey Ignatov wrote: > > > > > > Andrii Nakryiko [Tue, 2019-08-13 16:24 -0700]: > > > > Currently libbpf version is specified in 2 places: libbpf.map an

Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-14 Thread Andrey Ignatov
Andrii Nakryiko [Tue, 2019-08-13 21:46 -0700]: > On Tue, Aug 13, 2019 at 5:28 PM Andrey Ignatov wrote: > > > > Andrii Nakryiko [Tue, 2019-08-13 16:24 -0700]: > > > Currently libbpf version is specified in 2 places: libbpf.map and > > > Makefile. They easily get out of sync and it's very easy to

Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-13 Thread Andrii Nakryiko
On Tue, Aug 13, 2019 at 5:51 PM Jakub Kicinski wrote: > > On Tue, 13 Aug 2019 16:24:08 -0700, Andrii Nakryiko wrote: > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > > index 9312066a1ae3..d9afc8509725 100644 > > --- a/tools/lib/bpf/Makefile > > +++ b/tools/lib/bpf/Makefile > > @@

Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-13 Thread Andrii Nakryiko
On Tue, Aug 13, 2019 at 5:28 PM Andrey Ignatov wrote: > > Andrii Nakryiko [Tue, 2019-08-13 16:24 -0700]: > > Currently libbpf version is specified in 2 places: libbpf.map and > > Makefile. They easily get out of sync and it's very easy to update one, > > but forget to update another one. In addit

Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-13 Thread Jakub Kicinski
On Tue, 13 Aug 2019 16:24:08 -0700, Andrii Nakryiko wrote: > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > index 9312066a1ae3..d9afc8509725 100644 > --- a/tools/lib/bpf/Makefile > +++ b/tools/lib/bpf/Makefile > @@ -1,9 +1,10 @@ > # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Claus

Re: [PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-13 Thread Andrey Ignatov
Andrii Nakryiko [Tue, 2019-08-13 16:24 -0700]: > Currently libbpf version is specified in 2 places: libbpf.map and > Makefile. They easily get out of sync and it's very easy to update one, > but forget to update another one. In addition, Github projection of > libbpf has to maintain its own versio

[PATCH bpf-next] libbpf: make libbpf.map source of truth for libbpf version

2019-08-13 Thread Andrii Nakryiko
Currently libbpf version is specified in 2 places: libbpf.map and Makefile. They easily get out of sync and it's very easy to update one, but forget to update another one. In addition, Github projection of libbpf has to maintain its own version which has to be remembered to be kept in sync manually