Re: [PATCH bpf-next] i40e: fix xdp handle calculations

2019-09-17 Thread Björn Töpel
On 2019-09-17 12:48, Maxim Mikityanskiy wrote: Hi, it looks to me that headroom is still broken after this commit. i40e_run_xdp_zc adds it a second time, i.e.: Indeed, but Ciara fixed that in this series [1]. Thanks for reviewing the patch! Cheers, Björn [1] https://lore.kernel.org/bpf/20190

Re: [PATCH bpf-next] i40e: fix xdp handle calculations

2019-09-17 Thread Maxim Mikityanskiy
On Thu, Sep 5, 2019 at 4:11 AM Kevin Laatz wrote: > > Currently, we don't add headroom to the handle in i40e_zca_free, > i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc. The addition of the > headroom to the handle was removed in > commit 2f86c806a8a8 ("i40e: modify driver for handling offsets"

Re: [PATCH bpf-next] i40e: fix xdp handle calculations

2019-09-05 Thread Daniel Borkmann
On 9/5/19 3:11 AM, Kevin Laatz wrote: Currently, we don't add headroom to the handle in i40e_zca_free, i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc. The addition of the headroom to the handle was removed in commit 2f86c806a8a8 ("i40e: modify driver for handling offsets"), which will break t

Re: [Intel-wired-lan] [PATCH bpf-next] i40e: fix xdp handle calculations

2019-09-05 Thread Björn Töpel
On Thu, 5 Sep 2019 at 11:27, Kevin Laatz wrote: > > Currently, we don't add headroom to the handle in i40e_zca_free, > i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc. The addition of the > headroom to the handle was removed in > commit 2f86c806a8a8 ("i40e: modify driver for handling offsets"),

[PATCH bpf-next] i40e: fix xdp handle calculations

2019-09-05 Thread Kevin Laatz
Currently, we don't add headroom to the handle in i40e_zca_free, i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc. The addition of the headroom to the handle was removed in commit 2f86c806a8a8 ("i40e: modify driver for handling offsets"), which will break things when headroom is non-zero. This pa