Re: [PATCH bpf-next] flow_dissector: lookup netns by skb->sk if skb->dev is NULL

2018-09-26 Thread Eric Dumazet
On 09/25/2018 08:38 AM, Daniel Borkmann wrote: > On 09/24/2018 10:49 PM, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> BPF flow dissectors are configured per network namespace. >> __skb_flow_dissect looks up the netns through dev_net(skb->dev). >> >> In some dissector paths skb->dev i

Re: [PATCH bpf-next] flow_dissector: lookup netns by skb->sk if skb->dev is NULL

2018-09-25 Thread Daniel Borkmann
On 09/24/2018 10:49 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > BPF flow dissectors are configured per network namespace. > __skb_flow_dissect looks up the netns through dev_net(skb->dev). > > In some dissector paths skb->dev is NULL, such as for Unix sockets. > In these cases fall

Re: [PATCH bpf-next] flow_dissector: lookup netns by skb->sk if skb->dev is NULL

2018-09-24 Thread Song Liu
On Mon, Sep 24, 2018 at 1:52 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > BPF flow dissectors are configured per network namespace. > __skb_flow_dissect looks up the netns through dev_net(skb->dev). > > In some dissector paths skb->dev is NULL, such as for Unix sockets. > In these ca

[PATCH bpf-next] flow_dissector: lookup netns by skb->sk if skb->dev is NULL

2018-09-24 Thread Willem de Bruijn
From: Willem de Bruijn BPF flow dissectors are configured per network namespace. __skb_flow_dissect looks up the netns through dev_net(skb->dev). In some dissector paths skb->dev is NULL, such as for Unix sockets. In these cases fall back to looking up the netns by socket. Analyzing the codepat