Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-05 Thread Yafang Shao
On Tue, Feb 5, 2019 at 4:23 AM Daniel Borkmann wrote: > > On 02/04/2019 06:35 PM, Alexei Starovoitov wrote: > > On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: > >> Then we can enable/disable socket debugging without modifying user code. > >> That is more convenient for debugging. > >

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-05 Thread Yafang Shao
On Tue, Feb 5, 2019 at 1:35 AM Alexei Starovoitov wrote: > > On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: > > Then we can enable/disable socket debugging without modifying user code. > > That is more convenient for debugging. > > > > Signed-off-by: Yafang Shao > > --- > > include

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-04 Thread Daniel Borkmann
On 02/04/2019 06:35 PM, Alexei Starovoitov wrote: > On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: >> Then we can enable/disable socket debugging without modifying user code. >> That is more convenient for debugging. >> >> Signed-off-by: Yafang Shao >> --- >> include/net/sock.h | 8

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-04 Thread Alexei Starovoitov
On Sun, Feb 03, 2019 at 04:15:07PM +0800, Yafang Shao wrote: > Then we can enable/disable socket debugging without modifying user code. > That is more convenient for debugging. > > Signed-off-by: Yafang Shao > --- > include/net/sock.h | 8 > net/core/filter.c | 3 +++ > net/core/sock.c

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-04 Thread Quentin Monnet
2019-02-03 16:15 UTC+0800 ~ Yafang Shao > Then we can enable/disable socket debugging without modifying user code. > That is more convenient for debugging. > > Signed-off-by: Yafang Shao Hi Yafang, The list of socketopts supported by bpf_setsockopt() is described in the documentation for this

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-03 Thread Lawrence Brakmo
On 2/3/19, 12:15 AM, "Yafang Shao" wrote: Then we can enable/disable socket debugging without modifying user code. That is more convenient for debugging. Signed-off-by: Yafang Shao Acked-by: Lawrence Brakmo --- include/net/sock.h | 8 net/core/filter.c

Re: [PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-03 Thread Y Song
On Sun, Feb 3, 2019 at 12:18 AM Yafang Shao wrote: > > Then we can enable/disable socket debugging without modifying user code. > That is more convenient for debugging. > > Signed-off-by: Yafang Shao Acked-by: Yonghong Song > --- > include/net/sock.h | 8 > net/core/filter.c | 3 +++

[PATCH bpf-next] bpf: support SO_DEBUG in bpf_setsockopt()

2019-02-03 Thread Yafang Shao
Then we can enable/disable socket debugging without modifying user code. That is more convenient for debugging. Signed-off-by: Yafang Shao --- include/net/sock.h | 8 net/core/filter.c | 3 +++ net/core/sock.c| 8 3 files changed, 11 insertions(+), 8 deletions(-) diff --g