Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-29 Thread Prashant Bhole
On 3/28/2018 5:51 PM, Daniel Borkmann wrote: On 03/28/2018 08:18 AM, Prashant Bhole wrote: On 3/27/2018 6:05 PM, Daniel Borkmann wrote: On 03/27/2018 10:41 AM, Prashant Bhole wrote: On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: When CONFIG_DEBUG

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-28 Thread Daniel Borkmann
On 03/28/2018 08:18 AM, Prashant Bhole wrote: > On 3/27/2018 6:05 PM, Daniel Borkmann wrote: >> On 03/27/2018 10:41 AM, Prashant Bhole wrote: >>> On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: > When CONFIG_DEBUG_SG is set, sg->sg_magic is initia

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-27 Thread Prashant Bhole
On 3/27/2018 6:05 PM, Daniel Borkmann wrote: On 03/27/2018 10:41 AM, Prashant Bhole wrote: On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, when sg table is initialized using sg_in

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-27 Thread Daniel Borkmann
On 03/27/2018 10:41 AM, Prashant Bhole wrote: > On 3/27/2018 12:15 PM, John Fastabend wrote: >> On 03/25/2018 11:54 PM, Prashant Bhole wrote: >>> When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, >>> when sg table is initialized using sg_init_table(). Magic is checked >>> while

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-27 Thread Prashant Bhole
On 3/27/2018 12:15 PM, John Fastabend wrote: On 03/25/2018 11:54 PM, Prashant Bhole wrote: When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, when sg table is initialized using sg_init_table(). Magic is checked while navigating the scatterlist. We hit BUG_ON when magic check

Re: [PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-26 Thread John Fastabend
On 03/25/2018 11:54 PM, Prashant Bhole wrote: > When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, > when sg table is initialized using sg_init_table(). Magic is checked > while navigating the scatterlist. We hit BUG_ON when magic check is > failed. > > Fixed following things: >

[PATCH bpf-next] bpf: sockmap: initialize sg table entries properly

2018-03-25 Thread Prashant Bhole
When CONFIG_DEBUG_SG is set, sg->sg_magic is initialized to SG_MAGIC, when sg table is initialized using sg_init_table(). Magic is checked while navigating the scatterlist. We hit BUG_ON when magic check is failed. Fixed following things: - Initialization of sg table in bpf_tcp_sendpage() was miss