Re: [PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-17 Thread Alexei Starovoitov
On Mon, Dec 17, 2018 at 09:39:47AM +, Quentin Monnet wrote: > 2018-12-16 00:49 UTC+0100 ~ Daniel Borkmann > > Existing libraries and tracing frameworks work around this kernel > > version check by automatically deriving the kernel version from > > uname(3) or similar such that the user does no

Re: [PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-17 Thread Quentin Monnet
2018-12-17 10:57 UTC+0100 ~ Daniel Borkmann On 12/17/2018 10:39 AM, Quentin Monnet wrote: [...] Note: samples and selftests setting a kern_version can probably wait before being updated (if they get updated at all), but you might want to change now the remark in Documentation/bpf/bpf_design_Q

Re: [PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-17 Thread Daniel Borkmann
On 12/17/2018 10:39 AM, Quentin Monnet wrote: [...] > Note: samples and selftests setting a kern_version can probably wait before > being updated (if they get updated at all), but you might want to change now > the remark in Documentation/bpf/bpf_design_QA.rst about kern_version being > checked.

Re: [PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-17 Thread Quentin Monnet
2018-12-16 00:49 UTC+0100 ~ Daniel Borkmann Existing libraries and tracing frameworks work around this kernel version check by automatically deriving the kernel version from uname(3) or similar such that the user does not need to do it manually; these workarounds also make the version check usel

[PATCH bpf-next] bpf: remove useless version check for prog load

2018-12-15 Thread Daniel Borkmann
Existing libraries and tracing frameworks work around this kernel version check by automatically deriving the kernel version from uname(3) or similar such that the user does not need to do it manually; these workarounds also make the version check useless at the same time. Moreover, most other BPF