Re: [PATCH bpf-next] bpf: remove useless variable

2018-12-14 Thread Daniel Borkmann
On 12/14/2018 06:03 PM, Martin Lau wrote: > On Thu, Dec 13, 2018 at 10:44:57PM +0100, Andrea Claudi wrote: >> bytes is initialized to end - start at the beginning of this function, >> and is never changed. Remove it making the code a bit more readable. >> >> Suggested-by: Stefano Brivio >> Signed-

Re: [PATCH bpf-next] bpf: remove useless variable

2018-12-14 Thread Stefano Brivio
On Fri, 14 Dec 2018 17:03:02 + Martin Lau wrote: > On Thu, Dec 13, 2018 at 10:44:57PM +0100, Andrea Claudi wrote: > > bytes is initialized to end - start at the beginning of this function, > > and is never changed. Remove it making the code a bit more readable. > > > > Suggested-by: Stefano

Re: [PATCH bpf-next] bpf: remove useless variable

2018-12-14 Thread Martin Lau
On Thu, Dec 13, 2018 at 10:44:57PM +0100, Andrea Claudi wrote: > bytes is initialized to end - start at the beginning of this function, > and is never changed. Remove it making the code a bit more readable. > > Suggested-by: Stefano Brivio > Signed-off-by: Andrea Claudi The change looks correct.

Re: [PATCH bpf-next] bpf: remove useless variable

2018-12-14 Thread Stefano Brivio
On Thu, 13 Dec 2018 22:44:57 +0100 Andrea Claudi wrote: > bytes is initialized to end - start at the beginning of this function, > and is never changed. Remove it making the code a bit more readable. > > Suggested-by: Stefano Brivio > Signed-off-by: Andrea Claudi Reviewed-by: Stefano Brivio

[PATCH bpf-next] bpf: remove useless variable

2018-12-13 Thread Andrea Claudi
bytes is initialized to end - start at the beginning of this function, and is never changed. Remove it making the code a bit more readable. Suggested-by: Stefano Brivio Signed-off-by: Andrea Claudi --- net/core/filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/n