Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-21 Thread Daniel Borkmann
On 11/21/2018 07:48 PM, Vlad Dumitrescu wrote: > On Wed, Nov 21, 2018 at 5:08 AM Eric Dumazet wrote: >> On 11/20/2018 06:40 PM, Alexei Starovoitov wrote: >>> >>> looks good to me. >>> >>> Any particular reason you decided to disable it for cg_skb ? >>> It seems to me the same EDT approach will wor

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-21 Thread Alexei Starovoitov
On Wed, Nov 21, 2018 at 10:48:21AM -0800, Vlad Dumitrescu wrote: > On Wed, Nov 21, 2018 at 5:08 AM Eric Dumazet wrote: > > > > > > > > On 11/20/2018 06:40 PM, Alexei Starovoitov wrote: > > > > > > > > looks good to me. > > > > > > Any particular reason you decided to disable it for cg_skb ? > > >

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-21 Thread Vlad Dumitrescu
On Wed, Nov 21, 2018 at 5:08 AM Eric Dumazet wrote: > > > > On 11/20/2018 06:40 PM, Alexei Starovoitov wrote: > > > > > looks good to me. > > > > Any particular reason you decided to disable it for cg_skb ? > > It seems to me the same EDT approach will work from > > cgroup-bpf skb hooks just as we

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-21 Thread Eric Dumazet
On 11/20/2018 06:40 PM, Alexei Starovoitov wrote: > > looks good to me. > > Any particular reason you decided to disable it for cg_skb ? > It seems to me the same EDT approach will work from > cgroup-bpf skb hooks just as well and then we can have neat > way of controlling traffic per-contain

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-20 Thread Alexei Starovoitov
On Tue, Nov 20, 2018 at 07:18:48PM -0500, Vlad Dumitrescu wrote: > This could be used to rate limit egress traffic in concert with a qdisc > which supports Earliest Departure Time, such as FQ. > > Signed-off-by: Vlad Dumitrescu > --- > include/uapi/linux/bpf.h| 1 + > net/co

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-20 Thread Willem de Bruijn
On Tue, Nov 20, 2018 at 8:22 PM Eric Dumazet wrote: > > > > On 11/20/2018 04:18 PM, Vlad Dumitrescu wrote: > > This could be used to rate limit egress traffic in concert with a qdisc > > which supports Earliest Departure Time, such as FQ. > > > > Signed-off-by: Vlad Dumitrescu > > --- > > includ

Re: [PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-20 Thread Eric Dumazet
On 11/20/2018 04:18 PM, Vlad Dumitrescu wrote: > This could be used to rate limit egress traffic in concert with a qdisc > which supports Earliest Departure Time, such as FQ. > > Signed-off-by: Vlad Dumitrescu > --- > include/uapi/linux/bpf.h| 1 + > net/core/filter.c

[PATCH bpf-next] bpf: add read/write access to skb->tstamp from tc clsact progs

2018-11-20 Thread Vlad Dumitrescu
This could be used to rate limit egress traffic in concert with a qdisc which supports Earliest Departure Time, such as FQ. Signed-off-by: Vlad Dumitrescu --- include/uapi/linux/bpf.h| 1 + net/core/filter.c | 26 + tools/include