Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-19 Thread Nitin Hande
On Fri, 19 Oct 2018 22:32:28 +0200 Daniel Borkmann wrote: > On 10/19/2018 06:47 PM, Joe Stringer wrote: > > On Thu, 18 Oct 2018 at 22:07, Martin Lau wrote: > >> On Thu, Oct 18, 2018 at 04:52:40PM -0700, Joe Stringer wrote: > >>> On Thu, 18 Oct 2018 at 14:20, Daniel Borkmann > >>> wrote: >

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-19 Thread Daniel Borkmann
On 10/19/2018 06:47 PM, Joe Stringer wrote: > On Thu, 18 Oct 2018 at 22:07, Martin Lau wrote: >> On Thu, Oct 18, 2018 at 04:52:40PM -0700, Joe Stringer wrote: >>> On Thu, 18 Oct 2018 at 14:20, Daniel Borkmann wrote: On 10/18/2018 11:06 PM, Joe Stringer wrote: > On Thu, 18 Oct 2018 at 11:

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-19 Thread Joe Stringer
On Thu, 18 Oct 2018 at 22:07, Martin Lau wrote: > > On Thu, Oct 18, 2018 at 04:52:40PM -0700, Joe Stringer wrote: > > On Thu, 18 Oct 2018 at 14:20, Daniel Borkmann wrote: > > > > > > On 10/18/2018 11:06 PM, Joe Stringer wrote: > > > > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > > > [...]

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Martin Lau
On Thu, Oct 18, 2018 at 04:52:40PM -0700, Joe Stringer wrote: > On Thu, 18 Oct 2018 at 14:20, Daniel Borkmann wrote: > > > > On 10/18/2018 11:06 PM, Joe Stringer wrote: > > > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > > [...] > > >> Open Issue > > >> * The underlying code relies on presen

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Joe Stringer
On Thu, 18 Oct 2018 at 14:20, Daniel Borkmann wrote: > > On 10/18/2018 11:06 PM, Joe Stringer wrote: > > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > [...] > >> Open Issue > >> * The underlying code relies on presence of an skb to find out the > >> right sk for the case of REUSEPORT socket

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Nitin Hande
On Thu, 18 Oct 2018 23:20:17 +0200 Daniel Borkmann wrote: > On 10/18/2018 11:06 PM, Joe Stringer wrote: > > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > [...] > >> Open Issue > >> * The underlying code relies on presence of an skb to find out the > >> right sk for the case of REUSEPORT s

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Daniel Borkmann
On 10/18/2018 11:06 PM, Joe Stringer wrote: > On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: [...] >> Open Issue >> * The underlying code relies on presence of an skb to find out the >> right sk for the case of REUSEPORT socket option. Since there is >> no skb available at XDP hookpoint, the hel

Re: [PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Joe Stringer
On Thu, 18 Oct 2018 at 11:54, Nitin Hande wrote: > > > This patch proposes to extend the sk_lookup() BPF API to the > XDP hookpoint. The sk_lookup() helper supports a lookup > on incoming packet to find the corresponding socket that will > receive this packet. Current support for this BPF API is >

[PATCH bpf-next] bpf: Extend the sk_lookup() helper to XDP hookpoint.

2018-10-18 Thread Nitin Hande
This patch proposes to extend the sk_lookup() BPF API to the XDP hookpoint. The sk_lookup() helper supports a lookup on incoming packet to find the corresponding socket that will receive this packet. Current support for this BPF API is at the tc hookpoint. This patch will extend this API at XDP h