Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-02 Thread Björn Töpel
Den ons 1 aug. 2018 kl 22:25 skrev Daniel Borkmann : > > On 08/01/2018 04:43 PM, Björn Töpel wrote: > > Den ons 1 aug. 2018 kl 16:14 skrev Jesper Dangaard Brouer > > : > >> On Mon, 23 Jul 2018 11:41:02 +0200 > >> Björn Töpel wrote: > >> > >> diff --git a/net/core/xdp.c b/net/core/xdp.c >

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Daniel Borkmann
On 08/01/2018 04:43 PM, Björn Töpel wrote: > Den ons 1 aug. 2018 kl 16:14 skrev Jesper Dangaard Brouer : >> On Mon, 23 Jul 2018 11:41:02 +0200 >> Björn Töpel wrote: >> >> diff --git a/net/core/xdp.c b/net/core/xdp.c >> index 9d1f220..1c12bc7 100644 >> --- a/net/core/xdp.c >> +++ b/

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Björn Töpel
Den ons 1 aug. 2018 kl 16:14 skrev Jesper Dangaard Brouer : > > On Mon, 23 Jul 2018 11:41:02 +0200 > Björn Töpel wrote: > > > > >> diff --git a/net/core/xdp.c b/net/core/xdp.c > > > >> index 9d1f220..1c12bc7 100644 > > > >> --- a/net/core/xdp.c > > > >> +++ b/net/core/xdp.c > > > >> @@ -345,7 +345

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-08-01 Thread Jesper Dangaard Brouer
On Mon, 23 Jul 2018 11:41:02 +0200 Björn Töpel wrote: > > >> diff --git a/net/core/xdp.c b/net/core/xdp.c > > >> index 9d1f220..1c12bc7 100644 > > >> --- a/net/core/xdp.c > > >> +++ b/net/core/xdp.c > > >> @@ -345,7 +345,8 @@ static void __xdp_return(void *data, struct > > >> xdp_mem_info *mem,

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-26 Thread Jakub Kicinski
On Thu, 26 Jul 2018 14:13:20 +0200, Björn Töpel wrote: > Den mån 23 juli 2018 kl 21:58 skrev Jakub Kicinski: > > On Mon, 23 Jul 2018 11:39:36 +0200, Björn Töpel wrote: > > > Den fre 20 juli 2018 kl 22:08 skrev Jakub Kicinski: > > > > On Fri, 20 Jul 2018 10:18:21 -0700, Martin KaFai Lau wrote:

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-26 Thread Björn Töpel
Den mån 23 juli 2018 kl 21:58 skrev Jakub Kicinski : > > On Mon, 23 Jul 2018 11:39:36 +0200, Björn Töpel wrote: > > Den fre 20 juli 2018 kl 22:08 skrev Jakub Kicinski: > > > On Fri, 20 Jul 2018 10:18:21 -0700, Martin KaFai Lau wrote: > > > > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrot

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-23 Thread Jakub Kicinski
On Mon, 23 Jul 2018 11:39:36 +0200, Björn Töpel wrote: > Den fre 20 juli 2018 kl 22:08 skrev Jakub Kicinski: > > On Fri, 20 Jul 2018 10:18:21 -0700, Martin KaFai Lau wrote: > > > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: > > > > rhashtable_lookup() can return NULL. so that NUL

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-23 Thread Taehee Yoo
2018-07-23 18:41 GMT+09:00 Björn Töpel : > Den lör 21 juli 2018 kl 14:58 skrev Taehee Yoo : >> >> 2018-07-21 2:18 GMT+09:00 Martin KaFai Lau : >> > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: >> >> rhashtable_lookup() can return NULL. so that NULL pointer >> >> check routine should

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-23 Thread Björn Töpel
Den lör 21 juli 2018 kl 14:58 skrev Taehee Yoo : > > 2018-07-21 2:18 GMT+09:00 Martin KaFai Lau : > > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: > >> rhashtable_lookup() can return NULL. so that NULL pointer > >> check routine should be added. > >> > >> Fixes: 02b55e5657c3 ("xdp: a

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-23 Thread Björn Töpel
Den fre 20 juli 2018 kl 22:08 skrev Jakub Kicinski : > > On Fri, 20 Jul 2018 10:18:21 -0700, Martin KaFai Lau wrote: > > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: > > > rhashtable_lookup() can return NULL. so that NULL pointer > > > check routine should be added. > > > > > > Fixes

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-21 Thread Taehee Yoo
2018-07-21 2:18 GMT+09:00 Martin KaFai Lau : > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: >> rhashtable_lookup() can return NULL. so that NULL pointer >> check routine should be added. >> >> Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") >> Signed-off-by: Taehee Yoo >> --- >>

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-20 Thread Jakub Kicinski
On Fri, 20 Jul 2018 10:18:21 -0700, Martin KaFai Lau wrote: > On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: > > rhashtable_lookup() can return NULL. so that NULL pointer > > check routine should be added. > > > > Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") > > Signed-off-by:

Re: [PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-20 Thread Martin KaFai Lau
On Sat, Jul 21, 2018 at 01:04:45AM +0900, Taehee Yoo wrote: > rhashtable_lookup() can return NULL. so that NULL pointer > check routine should be added. > > Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") > Signed-off-by: Taehee Yoo > --- > net/core/xdp.c | 3 ++- > 1 file changed, 2 inserti

[PATCH bpf] xdp: add NULL pointer check in __xdp_return()

2018-07-20 Thread Taehee Yoo
rhashtable_lookup() can return NULL. so that NULL pointer check routine should be added. Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY") Signed-off-by: Taehee Yoo --- net/core/xdp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/xdp.c b/net/core/xdp.c index 9d