Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-03 Thread Björn Töpel
On Thu, 3 Oct 2019 at 19:16, Andrii Nakryiko wrote: > > On Thu, Oct 3, 2019 at 3:52 AM Björn Töpel wrote: > > > > On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada > > wrote: > > > > > > On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel wrote: > > > > > > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk >

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-03 Thread Andrii Nakryiko
On Thu, Oct 3, 2019 at 3:52 AM Björn Töpel wrote: > > On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada > wrote: > > > > On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel wrote: > > > > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk > > > wrote: > > > > > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200,

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-03 Thread Björn Töpel
On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada wrote: > > On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel wrote: > > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk > > wrote: > > > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: > > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-03 Thread Masahiro Yamada
On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel wrote: > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk > wrote: > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada > > > wrote: > > >> > > >[...] > > >> > Yes, the BPF samples require

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-02 Thread Björn Töpel
On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk wrote: > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada > > wrote: > >> > >[...] > >> > Yes, the BPF samples require clang/LLVM with BPF support to build. Any > >> > suggestion on a good wa

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-02 Thread Ivan Khoronzhuk
On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote: On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada wrote: [...] > Yes, the BPF samples require clang/LLVM with BPF support to build. Any > suggestion on a good way to address this (missing tools), better than > the warning above? After t

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-02 Thread Björn Töpel
On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada wrote: > [...] > > Yes, the BPF samples require clang/LLVM with BPF support to build. Any > > suggestion on a good way to address this (missing tools), better than > > the warning above? After the commit 394053f4a4b3 ("kbuild: make single > > targets wo

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-01 Thread Masahiro Yamada
On Tue, Oct 1, 2019 at 11:16 PM Björn Töpel wrote: > > On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada > wrote: > > > > Hi Bjorn > > > > On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel wrote: > > > > [...] > > > subdir-$(CONFIG_SAMPLE_VFS)+= vfs > > > +subdir-$(CONFIG_SAMPLE_BPF)

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-01 Thread Björn Töpel
On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada wrote: > > Hi Bjorn > > On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel wrote: > > [...] > > subdir-$(CONFIG_SAMPLE_VFS)+= vfs > > +subdir-$(CONFIG_SAMPLE_BPF)+= bpf > > > Please keep samples/Makefile sorted alphabetically. > Thank

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-01 Thread Masahiro Yamada
Hi Bjorn On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel wrote: > > From: Björn Töpel > > This commit makes it possible to build the BPF samples via a Kconfig > option, CONFIG_SAMPLE_BPF. Further, it fixes that samples/bpf/ could > not be built due to a missing samples/Makefile subdir-y entry, after

Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-01 Thread Björn Töpel
On Tue, 1 Oct 2019 at 12:14, Björn Töpel wrote: > > From: Björn Töpel > > This commit makes it possible to build the BPF samples via a Kconfig > option, CONFIG_SAMPLE_BPF. Further, it fixes that samples/bpf/ could > not be built due to a missing samples/Makefile subdir-y entry, after > the introd

[PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

2019-10-01 Thread Björn Töpel
From: Björn Töpel This commit makes it possible to build the BPF samples via a Kconfig option, CONFIG_SAMPLE_BPF. Further, it fixes that samples/bpf/ could not be built due to a missing samples/Makefile subdir-y entry, after the introduction of commit 394053f4a4b3 ("kbuild: make single targets wo