Re: [PATCH bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-03 Thread Jiong Wang
On 03/12/2018 22:04, Paul Burton wrote: Hi Jiong, On Sat, Dec 01, 2018 at 04:10:01AM -0500, Jiong Wang wrote: For micro-mips, srlv inside POOL32A encoding space should use 0x50 sub-opcode, NOT 0x90. Some early version ISA doc describes the encoding as 0x90 for both srlv and srav, this looks to

Re: [PATCH bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-03 Thread Paul Burton
Hi Jiong, On Sat, Dec 01, 2018 at 04:10:01AM -0500, Jiong Wang wrote: > For micro-mips, srlv inside POOL32A encoding space should use 0x50 > sub-opcode, NOT 0x90. > > Some early version ISA doc describes the encoding as 0x90 for both srlv and > srav, this looks to me was a typo. I checked Binutil

Re: [PATCH bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-02 Thread Song Liu
On Sat, Dec 1, 2018 at 1:12 AM Jiong Wang wrote: > > For micro-mips, srlv inside POOL32A encoding space should use 0x50 > sub-opcode, NOT 0x90. > > Some early version ISA doc describes the encoding as 0x90 for both srlv and > srav, this looks to me was a typo. I checked Binutils libopcode > implem

[PATCH bpf] mips: bpf: fix encoding bug for mm_srlv32_op

2018-12-01 Thread Jiong Wang
For micro-mips, srlv inside POOL32A encoding space should use 0x50 sub-opcode, NOT 0x90. Some early version ISA doc describes the encoding as 0x90 for both srlv and srav, this looks to me was a typo. I checked Binutils libopcode implementation which is using 0x50 for srlv and 0x90 for srav. Fixes