Re: [PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-05 Thread Alexei Starovoitov
On Fri, May 3, 2019 at 2:09 PM Y Song wrote: > > On Fri, May 3, 2019 at 12:54 PM William Tu wrote: > > > > On Thu, May 2, 2019 at 1:18 PM Y Song wrote: > > > > > > On Thu, May 2, 2019 at 11:34 AM William Tu wrote: > > > > > > > > The libbpf_util.h is used by xsk.h, so add it to > > > > the inst

Re: [PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-03 Thread Y Song
On Fri, May 3, 2019 at 12:54 PM William Tu wrote: > > On Thu, May 2, 2019 at 1:18 PM Y Song wrote: > > > > On Thu, May 2, 2019 at 11:34 AM William Tu wrote: > > > > > > The libbpf_util.h is used by xsk.h, so add it to > > > the install headers. > > > > Can we try to change code a little bit to a

Re: [PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-03 Thread William Tu
On Thu, May 2, 2019 at 1:18 PM Y Song wrote: > > On Thu, May 2, 2019 at 11:34 AM William Tu wrote: > > > > The libbpf_util.h is used by xsk.h, so add it to > > the install headers. > > Can we try to change code a little bit to avoid exposing libbpf_util.h? > Originally libbpf_util.h is considered

Re: [PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-02 Thread Y Song
On Thu, May 2, 2019 at 11:34 AM William Tu wrote: > > The libbpf_util.h is used by xsk.h, so add it to > the install headers. Can we try to change code a little bit to avoid exposing libbpf_util.h? Originally libbpf_util.h is considered as libbpf internal. I am not strongly against this patch. Bu

[PATCH bpf] libbpf: add libbpf_util.h to header install.

2019-05-02 Thread William Tu
The libbpf_util.h is used by xsk.h, so add it to the install headers. Reported-by: Ben Pfaff Signed-off-by: William Tu --- tools/lib/bpf/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index c6c06bc6683c..f91639bf5650 100644 --- a/too