Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-25 Thread Eric Dumazet
On Mon, Feb 25, 2019 at 3:07 AM Daniel Borkmann wrote: > > On 02/24/2019 12:11 AM, Alexei Starovoitov wrote: > > On Sat, Feb 23, 2019 at 12:48:53PM -0800, Eric Dumazet wrote: > >> On 02/23/2019 12:38 PM, Alexei Starovoitov wrote: > >>> On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote:

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-25 Thread Daniel Borkmann
On 02/24/2019 12:11 AM, Alexei Starovoitov wrote: > On Sat, Feb 23, 2019 at 12:48:53PM -0800, Eric Dumazet wrote: >> On 02/23/2019 12:38 PM, Alexei Starovoitov wrote: >>> On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: If caller of bpf_setsockopt() is silly passing a negative opt

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Alexei Starovoitov
On Sat, Feb 23, 2019 at 12:48:53PM -0800, Eric Dumazet wrote: > > > On 02/23/2019 12:38 PM, Alexei Starovoitov wrote: > > On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: > >> If caller of bpf_setsockopt() is silly passing a negative optlen > >> bad things happen. > >> > >> Fixes: 91

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Eric Dumazet
On 02/23/2019 12:38 PM, Alexei Starovoitov wrote: > On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: >> If caller of bpf_setsockopt() is silly passing a negative optlen >> bad things happen. >> >> Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") >> Signed-off

Re: [PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Alexei Starovoitov
On Sat, Feb 23, 2019 at 11:07:09AM -0800, Eric Dumazet wrote: > If caller of bpf_setsockopt() is silly passing a negative optlen > bad things happen. > > Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") > Signed-off-by: Eric Dumazet > Cc: Lawrence Brakmo > --- > net/core

[PATCH bpf] bpf: properly check TCP_CONGESTION optlen

2019-02-23 Thread Eric Dumazet
If caller of bpf_setsockopt() is silly passing a negative optlen bad things happen. Fixes: 91b5b21c7c16 ("bpf: Add support for changing congestion control") Signed-off-by: Eric Dumazet Cc: Lawrence Brakmo --- net/core/filter.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --g