Re: [PATCH bpf] bpf: only adjust gso_size on bytestream protocols

2019-02-11 Thread Willem de Bruijn
On Mon, Feb 11, 2019 at 9:58 AM Daniel Borkmann wrote: > > Hi Willem, > > On 02/11/2019 05:00 AM, Alexei Starovoitov wrote: > > On Thu, Feb 07, 2019 at 02:54:16PM -0500, Willem de Bruijn wrote: > >> From: Willem de Bruijn > >> > >> bpf_skb_change_proto and bpf_skb_adjust_room change skb header le

Re: [PATCH bpf] bpf: only adjust gso_size on bytestream protocols

2019-02-11 Thread Daniel Borkmann
Hi Willem, On 02/11/2019 05:00 AM, Alexei Starovoitov wrote: > On Thu, Feb 07, 2019 at 02:54:16PM -0500, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> bpf_skb_change_proto and bpf_skb_adjust_room change skb header length. >> For GSO packets they adjust gso_size to maintain the same MTU.

Re: [PATCH bpf] bpf: only adjust gso_size on bytestream protocols

2019-02-10 Thread Alexei Starovoitov
On Thu, Feb 07, 2019 at 02:54:16PM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > bpf_skb_change_proto and bpf_skb_adjust_room change skb header length. > For GSO packets they adjust gso_size to maintain the same MTU. > > The gso size can only be safely adjusted on bytestream protoc

[PATCH bpf] bpf: only adjust gso_size on bytestream protocols

2019-02-07 Thread Willem de Bruijn
From: Willem de Bruijn bpf_skb_change_proto and bpf_skb_adjust_room change skb header length. For GSO packets they adjust gso_size to maintain the same MTU. The gso size can only be safely adjusted on bytestream protocols. Commit d02f51cbcf12 ("bpf: fix bpf_skb_adjust_net/bpf_skb_proto_xlat to d