Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Ferenc Fejes
> > Hi Alexei, > > On 03/06/2020 20:14, Alexei Starovoitov wrote: > > On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > >> Hi Ferenc, > >> > >> On 03/06/2020 10:56, Ferenc Fejes wrote: > >>> Matthieu Baerts ezt írta (időpont: > >>> 2020. jún. 3., Sze, 10:11): > > A recen

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Alexei Starovoitov
On Wed, Jun 3, 2020 at 11:41 AM Matthieu Baerts wrote: > > Hi Alexei, > > On 03/06/2020 20:14, Alexei Starovoitov wrote: > > On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > >> Hi Ferenc, > >> > >> On 03/06/2020 10:56, Ferenc Fejes wrote: > >>> Matthieu Baerts ezt írta (időpont:

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Matthieu Baerts
Hi Alexei, On 03/06/2020 20:14, Alexei Starovoitov wrote: On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: Hi Ferenc, On 03/06/2020 10:56, Ferenc Fejes wrote: Matthieu Baerts ezt írta (időpont: 2020. jún. 3., Sze, 10:11): A recent commit added new variables only used if CON

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Alexei Starovoitov
On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > Hi Ferenc, > > On 03/06/2020 10:56, Ferenc Fejes wrote: > > Matthieu Baerts ezt írta (időpont: > > 2020. jún. 3., Sze, 10:11): > > > > > > A recent commit added new variables only used if CONFIG_NETDEVICES is > > > set. > > > >

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Matthieu Baerts
Hi Ferenc, On 03/06/2020 10:56, Ferenc Fejes wrote: Matthieu Baerts ezt írta (időpont: 2020. jún. 3., Sze, 10:11): A recent commit added new variables only used if CONFIG_NETDEVICES is set. Thank you for noticing and fixed this! A simple fix is to only declare these variables if the same

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Ferenc Fejes
Matthieu Baerts ezt írta (időpont: 2020. jún. 3., Sze, 10:11): > > A recent commit added new variables only used if CONFIG_NETDEVICES is > set. Thank you for noticing and fixed this! > A simple fix is to only declare these variables if the same > condition is valid. > > Other solutions could be

[PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Matthieu Baerts
A recent commit added new variables only used if CONFIG_NETDEVICES is set. A simple fix is to only declare these variables if the same condition is valid. Other solutions could be to move the code related to SO_BINDTODEVICE option from _bpf_setsockopt() function to a dedicated one or only declare