Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-15 Thread Daniel Borkmann
On 08/15/2018 02:08 AM, Roman Gushchin wrote: > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: >> On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: >>> Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers >>> to the cgroup storage") refactored the bpf

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-15 Thread Roman Gushchin
On Wed, Aug 15, 2018 at 02:30:11PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 14, 2018 at 05:08:44PM -0700, Roman Gushchin wrote: > > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > > > > Commit 394e40a29

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-15 Thread Alexei Starovoitov
On Tue, Aug 14, 2018 at 05:08:44PM -0700, Roman Gushchin wrote: > On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > > > Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers > > > to the cgroup stora

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-14 Thread Roman Gushchin
On Tue, Aug 14, 2018 at 04:59:45PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > > Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers > > to the cgroup storage") refactored the bpf_prog_array_copy_core() > > to accommodate new st

Re: [PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-14 Thread Alexei Starovoitov
On Tue, Aug 14, 2018 at 11:01:12AM -0700, Yonghong Song wrote: > Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers > to the cgroup storage") refactored the bpf_prog_array_copy_core() > to accommodate new structure bpf_prog_array_item which contains > bpf_prog array itself. > > In

[PATCH bpf] bpf: fix a rcu usage warning in bpf_prog_array_copy_core()

2018-08-14 Thread Yonghong Song
Commit 394e40a29788 ("bpf: extend bpf_prog_array to store pointers to the cgroup storage") refactored the bpf_prog_array_copy_core() to accommodate new structure bpf_prog_array_item which contains bpf_prog array itself. In the old code, we had perf_event_query_prog_array(): mutex_lock(...)