Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()

2019-02-10 Thread Alexei Starovoitov
On Sun, Feb 10, 2019 at 07:15:17AM +, Martin Lau wrote: > > > Fixes: c64b7983288e ("bpf: Add PTR_TO_SOCKET verifier type") > > > Cc: Joe Stringer > > > Signed-off-by: Martin KaFai Lau > > > > Applied to bpf tree. > Thanks! > > > > > Martin, if your is_fullsock work depends on it, I can app

Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()

2019-02-09 Thread Martin Lau
On Sat, Feb 09, 2019 at 08:02:43PM -0800, Alexei Starovoitov wrote: > On Fri, Feb 08, 2019 at 10:25:54PM -0800, Martin KaFai Lau wrote: > > By adding this test to test_verifier: > > { > > "reference tracking: access sk->src_ip4 (narrow load)", > > .insns = { > > BPF_SK_LOOKUP, > > B

Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()

2019-02-09 Thread Alexei Starovoitov
On Fri, Feb 08, 2019 at 10:25:54PM -0800, Martin KaFai Lau wrote: > By adding this test to test_verifier: > { > "reference tracking: access sk->src_ip4 (narrow load)", > .insns = { > BPF_SK_LOOKUP, > BPF_MOV64_REG(BPF_REG_6, BPF_REG_0), > BPF_JMP_IMM(BPF_JEQ, BPF_REG_0

Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()

2019-02-09 Thread Joe Stringer
On Fri, 8 Feb 2019 at 22:27, Martin KaFai Lau wrote: > > By adding this test to test_verifier: > { > "reference tracking: access sk->src_ip4 (narrow load)", > .insns = { > BPF_SK_LOOKUP, > BPF_MOV64_REG(BPF_REG_6, BPF_REG_0), > BPF_JMP_IMM(BPF_JEQ, BPF_REG_0

[PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()

2019-02-08 Thread Martin KaFai Lau
By adding this test to test_verifier: { "reference tracking: access sk->src_ip4 (narrow load)", .insns = { BPF_SK_LOOKUP, BPF_MOV64_REG(BPF_REG_6, BPF_REG_0), BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 3), BPF_LDX_MEM(BPF_H, BPF_REG_2, BPF_REG_0, offsetof(str