Re: [PATCH V6 mlx5-next 11/16] RDMA/core: Add LAG functionality

2020-04-29 Thread Jason Gunthorpe
On Wed, Apr 29, 2020 at 12:01:07PM +0300, Maor Gottlieb wrote: > > On 4/29/2020 2:30 AM, Jason Gunthorpe wrote: > > On Tue, Apr 28, 2020 at 08:15:25PM -0300, Jason Gunthorpe wrote: > > > On Sun, Apr 26, 2020 at 10:17:12AM +0300, Maor Gottlieb wrote: > > > > +int rdma_lag_get_ah_roce_slave(struct i

Re: [PATCH V6 mlx5-next 11/16] RDMA/core: Add LAG functionality

2020-04-29 Thread Maor Gottlieb
On 4/29/2020 2:30 AM, Jason Gunthorpe wrote: On Tue, Apr 28, 2020 at 08:15:25PM -0300, Jason Gunthorpe wrote: On Sun, Apr 26, 2020 at 10:17:12AM +0300, Maor Gottlieb wrote: +int rdma_lag_get_ah_roce_slave(struct ib_device *device, + struct rdma_ah_attr *ah_attr, +

Re: [PATCH V6 mlx5-next 11/16] RDMA/core: Add LAG functionality

2020-04-28 Thread Jason Gunthorpe
On Tue, Apr 28, 2020 at 08:15:25PM -0300, Jason Gunthorpe wrote: > On Sun, Apr 26, 2020 at 10:17:12AM +0300, Maor Gottlieb wrote: > > +int rdma_lag_get_ah_roce_slave(struct ib_device *device, > > + struct rdma_ah_attr *ah_attr, > > + struct net_devi

Re: [PATCH V6 mlx5-next 11/16] RDMA/core: Add LAG functionality

2020-04-28 Thread Jason Gunthorpe
On Sun, Apr 26, 2020 at 10:17:12AM +0300, Maor Gottlieb wrote: > +int rdma_lag_get_ah_roce_slave(struct ib_device *device, > +struct rdma_ah_attr *ah_attr, > +struct net_device **xmit_slave) Please do not use ** and also return int. The funct