Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-08-02 Thread Cong Wang
On Tue, Aug 1, 2017 at 2:42 PM, Shaohua Li wrote: > Is this really better? I don't see any point. I'd use my original patch other > than this one. that said, there are just several lines of code, brutally > 'abstract' them into a function doesn't make the code better. The current ip6_make_flowlab

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-08-01 Thread Shaohua Li
On Tue, Aug 01, 2017 at 02:17:58PM -0700, Cong Wang wrote: > On Mon, Jul 31, 2017 at 4:00 PM, Shaohua Li wrote: > > On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: > >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > >> > static inline __be32 ip6_make_flowlabel(struct net *net, s

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-08-01 Thread Cong Wang
On Mon, Jul 31, 2017 at 4:00 PM, Shaohua Li wrote: > On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: >> > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff >> > *skb, >> >

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Shaohua Li
On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: > On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff > > *skb, > > __be32 flowlabel, bool autolabel, > > -

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Cong Wang
On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb, > __be32 flowlabel, bool autolabel, > - struct flowi6 *fl6) > +

[PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

2017-07-31 Thread Shaohua Li
From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690, options [mss 65476,