Re: [PATCH V3 net-next 5/6] net: mdio: of: Register discovered MII time stampers.

2019-05-27 Thread Richard Cochran
On Wed, May 22, 2019 at 03:22:27AM +0200, Andrew Lunn wrote: > Shouldn't unregister_mii_timestamper() be called on error? Yes. Thanks, Richard

Re: [PATCH V3 net-next 5/6] net: mdio: of: Register discovered MII time stampers.

2019-05-21 Thread Andrew Lunn
> +struct mii_timestamper *of_find_mii_timestamper(struct device_node *node) > +{ > + struct of_phandle_args arg; > + int err; > + > + err = of_parse_phandle_with_fixed_args(node, "timestamper", 1, 0, &arg); > + > + if (err == -ENOENT) > + return NULL; > + else if (e

[PATCH V3 net-next 5/6] net: mdio: of: Register discovered MII time stampers.

2019-05-21 Thread Richard Cochran
When parsing a PHY node, register its time stamper, if any, and attach the instance to the PHY device. Signed-off-by: Richard Cochran --- drivers/net/phy/phy_device.c | 3 +++ drivers/of/of_mdio.c | 24 2 files changed, 27 insertions(+) diff --git a/drivers/net