Re: [PATCH V3 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers.

2019-05-27 Thread Richard Cochran
On Wed, May 22, 2019 at 03:08:52AM +0200, Andrew Lunn wrote: > probe_channel returns an PTR_ERR. So if (mii_ts) should probably be > if (IS_ERR(mii_ts)) Nice catch. Thanks for the careful review! Richard

Re: [PATCH V3 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers.

2019-05-21 Thread Andrew Lunn
> +struct mii_timestamper *register_mii_timestamper(struct device_node *node, > + unsigned int port) > +{ > + struct mii_timestamper *mii_ts = NULL; > + struct mii_timestamping_desc *desc; > + struct list_head *this; > + > + mutex_lock(&t

[PATCH V3 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers.

2019-05-21 Thread Richard Cochran
While PHY time stamping drivers can simply attach their interface directly to the PHY instance, stand alone drivers require support in order to manage their services. Non-PHY MII time stamping drivers have a control interface over another bus like I2C, SPI, UART, or via a memory mapped peripheral.