Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Marek Vasut
On 6/25/19 2:40 PM, Vladimir Oltean wrote: > On Tue, 25 Jun 2019 at 15:06, Marek Vasut wrote: >> >> On 6/25/19 1:59 AM, Vladimir Oltean wrote: >>> On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: On 6/24/19 12:35 AM, Marek Vasut wrote: > Add basic SPI regmap support into the driver.

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Vladimir Oltean
On Tue, 25 Jun 2019 at 15:06, Marek Vasut wrote: > > On 6/25/19 1:59 AM, Vladimir Oltean wrote: > > On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: > >> > >> On 6/24/19 12:35 AM, Marek Vasut wrote: > >>> Add basic SPI regmap support into the driver. > >>> > >>> Previous patches unconver that ksz

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Marek Vasut
On 6/25/19 1:59 AM, Vladimir Oltean wrote: > On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: >> >> On 6/24/19 12:35 AM, Marek Vasut wrote: >>> Add basic SPI regmap support into the driver. >>> >>> Previous patches unconver that ksz_spi_write() is always ever called >>> with len = 1, 2 or 4. We ca

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread kbuild test robot
Hi Marek, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v5.2-rc6 next-20190621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mar

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-24 Thread Vladimir Oltean
On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: > > On 6/24/19 12:35 AM, Marek Vasut wrote: > > Add basic SPI regmap support into the driver. > > > > Previous patches unconver that ksz_spi_write() is always ever called > > with len = 1, 2 or 4. We can thus drop the if (len > SPI_TX_BUF_LEN) > > c

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-24 Thread Marek Vasut
On 6/24/19 12:35 AM, Marek Vasut wrote: > Add basic SPI regmap support into the driver. > > Previous patches unconver that ksz_spi_write() is always ever called > with len = 1, 2 or 4. We can thus drop the if (len > SPI_TX_BUF_LEN) > check and we can also drop the allocation of the txbuf which is

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-24 Thread kbuild test robot
Hi Marek, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v5.2-rc6 next-20190621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com

[PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-23 Thread Marek Vasut
Add basic SPI regmap support into the driver. Previous patches unconver that ksz_spi_write() is always ever called with len = 1, 2 or 4. We can thus drop the if (len > SPI_TX_BUF_LEN) check and we can also drop the allocation of the txbuf which is part of the driver data and wastes 256 bytes for n