org
> > Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
> > functions
> >
> > On Mon, 2016-02-22 at 14:10 -0500, David Miller wrote:
> > > From:
> > > Date: Mon, 22 Feb 2016 18:28:18 +
> > >
> > > >
> -Original Message-
> From: Ben Hutchings [mailto:b...@decadent.org.uk]
> Sent: Monday, February 22, 2016 3:05 PM
> To: David Miller; Woojung Huh - C21699
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
> fu
On Mon, 2016-02-22 at 14:10 -0500, David Miller wrote:
> From:
> Date: Mon, 22 Feb 2016 18:28:18 +
>
> >> This is incorrect; you should always return the manual settings
> >> (fc_request_control flags) here. If autonegotiation is enabled then
> >> your get_settings function will return the a
From:
Date: Mon, 22 Feb 2016 18:28:18 +
>> This is incorrect; you should always return the manual settings
>> (fc_request_control flags) here. If autonegotiation is enabled then
>> your get_settings function will return the actual pause flags.
>>
> What do you mean "return actual pause flag
> This is incorrect; you should always return the manual settings
> (fc_request_control flags) here. If autonegotiation is enabled then
> your get_settings function will return the actual pause flags.
>
What do you mean "return actual pause flags" when autoneg is enabled?
Pause flags set by (or d
> -Original Message-
> From: Ben Hutchings [mailto:b...@decadent.org.uk]
> Sent: Thursday, February 18, 2016 8:21 PM
> To: Woojung Huh - C21699; da...@davemloft.net
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set &
On Fri, 2016-02-19 at 00:16 +, woojung@microchip.com wrote:
> > > Ben, thanks for comments.
> > > How about comment in include/uapi/linux/ethtool.h?
> > > It says
> > > ** struct ethtool_pauseparam - Ethernet pause (flow control) parameters
> > > ...
> > > * If @autoneg is non-zero, the MAC
> > Ben, thanks for comments.
> > How about comment in include/uapi/linux/ethtool.h?
> > It says
> > ** struct ethtool_pauseparam - Ethernet pause (flow control) parameters
> > ...
> > * If @autoneg is non-zero, the MAC is configured to send and/or
> > * receive pause frames according to the result
On Fri, 2016-02-19 at 00:03 +, woojung@microchip.com wrote:
> > > Add ethtool operations of set_pauseram and get_pauseparm.
> > [...]
> > > +static void lan78xx_get_pause(struct net_device *net,
> > > + struct ethtool_pauseparam *pause)
> > > +{
> > > + struct lan78xx_
> > Add ethtool operations of set_pauseram and get_pauseparm.
> [...]
> > +static void lan78xx_get_pause(struct net_device *net,
> > + struct ethtool_pauseparam *pause)
> > +{
> > + struct lan78xx_net *dev = netdev_priv(net);
> > + struct phy_device *phydev = net->phydev
On Thu, 2016-02-18 at 22:40 +, woojung@microchip.com wrote:
> Add ethtool operations of set_pauseram and get_pauseparm.
[...]
> +static void lan78xx_get_pause(struct net_device *net,
> + struct ethtool_pauseparam *pause)
> +{
> + struct lan78xx_net *dev = netde
Add ethtool operations of set_pauseram and get_pauseparm.
Signed-off-by: Woojung Huh
---
drivers/net/usb/lan78xx.c | 84 +--
1 file changed, 81 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 4ec2
12 matches
Mail list logo
