On Thu, 2018-03-22 at 01:27 +0300, Kirill Tkhai wrote:
> Hi, Saeed,
>
> thanks for fixing some of my remarks, but I've dived into the code
> more deeply, and found with a sadness, the patch lacks the
> readability.
>
> It too big and not fit kernel coding style. Please, see some comments
> below.
On 3/21/2018 11:10 PM, Eric Dumazet wrote:
On 03/21/2018 02:01 PM, Saeed Mahameed wrote:
From: Ilya Lesokhin
This patch adds a generic infrastructure to offload TLS crypto to a
...
+
+static inline int tls_push_record(struct sock *sk,
+ struct tls_contex
Hi, Saeed,
thanks for fixing some of my remarks, but I've dived into the code
more deeply, and found with a sadness, the patch lacks the readability.
It too big and not fit kernel coding style. Please, see some comments
below.
Can we do something with patch length? Is there a way to split it in
On 03/21/2018 02:01 PM, Saeed Mahameed wrote:
> From: Ilya Lesokhin
>
> This patch adds a generic infrastructure to offload TLS crypto to a
...
> +
> +static inline int tls_push_record(struct sock *sk,
> + struct tls_context *ctx,
> +
From: Ilya Lesokhin
This patch adds a generic infrastructure to offload TLS crypto to a
network devices. It enables the kernel TLS socket to skip encryption
and authentication operations on the transmit side of the data path.
Leaving those computationally expensive operations to the NIC.
The NIC
