Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-10 Thread Stephen Hemminger
On Thu, 8 Mar 2018 18:08:26 +0200 Tariq Toukan wrote: > TX rate limit fields are unsigned (__u32). > Use %u and print_uint when printing. > > Tested: > $ ip link set ens1 vf 1 rate 2294967296 > $ ip link show |grep -iE "vf 1" | grep rate > > before: > vf 1 MAC 00:00:00:00:00:00, tx rate -2

Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-08 Thread David Ahern
On 3/8/18 9:08 AM, Tariq Toukan wrote: > TX rate limit fields are unsigned (__u32). > Use %u and print_uint when printing. > > Tested: > $ ip link set ens1 vf 1 rate 2294967296 > $ ip link show |grep -iE "vf 1" | grep rate > > before: > vf 1 MAC 00:00:00:00:00:00, tx rate -20 (Mbps), max_

[PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits

2018-03-08 Thread Tariq Toukan
TX rate limit fields are unsigned (__u32). Use %u and print_uint when printing. Tested: $ ip link set ens1 vf 1 rate 2294967296 $ ip link show |grep -iE "vf 1" | grep rate before: vf 1 MAC 00:00:00:00:00:00, tx rate -20 (Mbps), max_tx_rate -20Mbps, ... after: vf 1 MAC 00:00:00:0