Re: [PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-20 Thread Jason Wang
On 2020/7/21 上午10:02, Zhu, Lingshan wrote: On 7/20/2020 5:40 PM, Jason Wang wrote: On 2020/7/20 下午5:07, Zhu, Lingshan wrote: +} + +static void vdpa_unsetup_irq(struct vdpa_device *vdev, int qid) +{ +    struct vdpa_driver *drv = drv_to_vdpa(vdev->dev.driver); + +    if (drv->unsetup_vq_ir

Re: [PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-20 Thread Jason Wang
On 2020/7/20 下午5:07, Zhu, Lingshan wrote: +} + +static void vdpa_unsetup_irq(struct vdpa_device *vdev, int qid) +{ +    struct vdpa_driver *drv = drv_to_vdpa(vdev->dev.driver); + +    if (drv->unsetup_vq_irq) +    drv->unsetup_vq_irq(vdev, qid); Do you need to check the existence of drv

Re: [PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-16 Thread Jason Wang
On 2020/7/16 下午7:23, Zhu Lingshan wrote: This commit implements IRQ offloading helpers Let's say "vq irq allocate/free helpers" here. in vDPA core by introducing two couple of functions: vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free irq, will setup irq offloading. vdp

[PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-16 Thread Zhu Lingshan
This commit implements IRQ offloading helpers in vDPA core by introducing two couple of functions: vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free irq, will setup irq offloading. vdpa_setup_irq() and vdpa_unsetup_irq(): supportive functions, will call vhost_vdpa helpers. Signed-