Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Marek Vasut
On 12/14/2018 09:11 PM, Andrew Lunn wrote: > On Fri, Dec 14, 2018 at 02:30:35PM +0100, Marek Vasut wrote: >> On 12/14/2018 10:05 AM, Andrew Lunn wrote: +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb, + struct net_device *dev, int len) { >

Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Andrew Lunn
On Fri, Dec 14, 2018 at 02:30:35PM +0100, Marek Vasut wrote: > On 12/14/2018 10:05 AM, Andrew Lunn wrote: > >> +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb, > >> + struct net_device *dev, int len) > >> { > >> - struct dsa_port *dp = dsa_slave_to_port

Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Marek Vasut
On 12/14/2018 10:05 AM, Andrew Lunn wrote: >> +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb, >> + struct net_device *dev, int len) >> { >> -struct dsa_port *dp = dsa_slave_to_port(dev); >> struct sk_buff *nskb; >> int padlen; >> -u8

Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Andrew Lunn
> +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb, > +struct net_device *dev, int len) > { > - struct dsa_port *dp = dsa_slave_to_port(dev); > struct sk_buff *nskb; > int padlen; > - u8 *tag; > > padlen = (skb->len >= ETH_

[PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-13 Thread Marek Vasut
From: Tristram Ha Factor out common code from the tag_ksz , so that the code can be used with other KSZ family switches which use differenly sized tags. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller -- V2: - Rebase on next/maste