Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Lorenzo Carletti
On Wed, Jan 27, 2021 at 12:17:37PM -0800, Florian Fainelli wrote: > One of those guidelines is no top-posting and make sure you use a > plaintext format for your emails otherwise the mailing-lists may be > dropping your response (we may still get those responses because we are > copied). My bad. I

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Linus Walleij
On Wed, Jan 27, 2021 at 2:07 AM Lorenzo Carletti wrote: > In the rtl8366rb driver there are some jam tables which contain > undocumented values. > While trying to understand what these tables actually do, > I noticed a discrepancy in how one of those was treated. > Most of them were plain u16 arr

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:06 PM, Lorenzo Carletti wrote: > In the rtl8366rb driver there are some jam tables which contain > undocumented values. > While trying to understand what these tables actually do, > I noticed a discrepancy in how one of those was treated. > Most of them were plain u16 arrays, whil

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
On 1/27/2021 12:06 PM, Lorenzo Carletti wrote: > Many thanks for telling me that and for showing me how this works. > I find both very useful. > I'll be sure to follow the guidelines more carefully next time. One of those guidelines is no top-posting and make sure you use a plaintext format for

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Vladimir Oltean
On Wed, Jan 27, 2021 at 02:06:32AM +0100, Lorenzo Carletti wrote: > In the rtl8366rb driver there are some jam tables which contain > undocumented values. > While trying to understand what these tables actually do, > I noticed a discrepancy in how one of those was treated. > Most of them were plain

[PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-26 Thread Lorenzo Carletti
In the rtl8366rb driver there are some jam tables which contain undocumented values. While trying to understand what these tables actually do, I noticed a discrepancy in how one of those was treated. Most of them were plain u16 arrays, while the ethernet one was an u16 matrix. By looking at the ven