Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-21 Thread Dinh Nguyen
On 04/21/2016 06:51 AM, Marek Vasut wrote: if you modify the patch to call stmmac_dvr_probe() before calling socfpga_dwmac_init(), then you would already have the reset control information. >>> >>> I was under the impression that you must call socfpga_dwmac_init() >>> before s

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-21 Thread Marek Vasut
On 04/21/2016 04:44 AM, Dinh Nguyen wrote: > > > On 04/20/2016 05:27 PM, Marek Vasut wrote: >> On 04/20/2016 11:17 PM, Dinh Nguyen wrote: >>> On 04/19/2016 07:05 PM, Marek Vasut wrote: Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() in stmmac_main.c functions c

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Dinh Nguyen
On 04/20/2016 05:27 PM, Marek Vasut wrote: > On 04/20/2016 11:17 PM, Dinh Nguyen wrote: >> On 04/19/2016 07:05 PM, Marek Vasut wrote: >>> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >>> in stmmac_main.c functions call devm_reset_control_get() to register an >>> reset

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Marek Vasut
On 04/20/2016 11:17 PM, Dinh Nguyen wrote: > On 04/19/2016 07:05 PM, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmmac. This results in an atte

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Dinh Nguyen
On 04/19/2016 07:05 PM, Marek Vasut wrote: > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset controllers for the

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-20 Thread Marek Vasut
On 04/20/2016 04:04 AM, Dinh Nguyen wrote: > > > On 04/19/2016 07:05 PM, Marek Vasut wrote: >> Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() >> in stmmac_main.c functions call devm_reset_control_get() to register an >> reset controller for the stmmac. This results in a

Re: [PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-19 Thread Dinh Nguyen
On 04/19/2016 07:05 PM, Marek Vasut wrote: > Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() > in stmmac_main.c functions call devm_reset_control_get() to register an > reset controller for the stmmac. This results in an attempt to register > two reset controllers for th

[PATCH V2] net: stmmac: socfpga: Remove re-registration of reset controller

2016-04-19 Thread Marek Vasut
Both socfpga_dwmac_parse_data() in dwmac-socfpga.c and stmmac_dvr_probe() in stmmac_main.c functions call devm_reset_control_get() to register an reset controller for the stmmac. This results in an attempt to register two reset controllers for the same non-shared reset line. The first attempt to r