Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-23 Thread Marek Vasut
On 12/22/18 6:24 PM, Heiner Kallweit wrote: > On 22.12.2018 00:22, Marek Vasut wrote: >> On 12/15/2018 06:38 PM, Heiner Kallweit wrote: >>> On 15.12.2018 18:01, Andrew Lunn wrote: > +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { > + { "phy_symbol_error_count", 20, 0, 0x },

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-22 Thread Heiner Kallweit
On 22.12.2018 00:22, Marek Vasut wrote: > On 12/15/2018 06:38 PM, Heiner Kallweit wrote: >> On 15.12.2018 18:01, Andrew Lunn wrote: +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { + { "phy_symbol_error_count", 20, 0, 0x }, + { "phy_overtemp_error", 21, 1, BIT(1) },

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-21 Thread Marek Vasut
On 12/15/2018 07:01 PM, Heiner Kallweit wrote: > On 14.12.2018 17:11, Marek Vasut wrote: >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >> BroadRReach 100BaseT1 PHYs used in automotive. >> >> Signed-off-by: Marek Vasut >> --- >> V2: - Use phy_modify(), phy_{set,clear}_b

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-21 Thread Marek Vasut
On 12/15/2018 06:38 PM, Heiner Kallweit wrote: > On 15.12.2018 18:01, Andrew Lunn wrote: >>> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { >>> + { "phy_symbol_error_count", 20, 0, 0x }, >>> + { "phy_overtemp_error", 21, 1, BIT(1) }, >>> + { "phy_undervolt_error", 21, 3, BIT(3) }

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Marek Vasut
On 12/15/2018 07:06 PM, Heiner Kallweit wrote: [...] >>> +static int tja11xx_config_init(struct phy_device *phydev) >>> +{ >>> + int ret; >>> + >>> + ret = tja11xx_enable_reg_write(phydev); >>> + if (ret) >>> + return ret; >>> + >>> + phydev->irq = PHY_POLL; >>> + phydev->auto

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Heiner Kallweit
On 15.12.2018 20:59, Andrew Lunn wrote: +static int tja11xx_config_init(struct phy_device *phydev) +{ + int ret; + + ret = tja11xx_enable_reg_write(phydev); + if (ret) + return ret; + + phydev->irq = PHY_POLL; + phydev->autoneg = AUTON

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Andrew Lunn
> >> +static int tja11xx_config_init(struct phy_device *phydev) > >> +{ > >> + int ret; > >> + > >> + ret = tja11xx_enable_reg_write(phydev); > >> + if (ret) > >> + return ret; > >> + > >> + phydev->irq = PHY_POLL; > >> + phydev->autoneg = AUTONEG_DISABLE; > >> + phydev->speed = SPEE

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Heiner Kallweit
On 15.12.2018 19:01, Heiner Kallweit wrote: > On 14.12.2018 17:11, Marek Vasut wrote: >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >> BroadRReach 100BaseT1 PHYs used in automotive. >> >> Signed-off-by: Marek Vasut >> --- >> V2: - Use phy_modify(), phy_{set,clear}_bits

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Heiner Kallweit
On 14.12.2018 17:11, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. > > Signed-off-by: Marek Vasut > --- > V2: - Use phy_modify(), phy_{set,clear}_bits() > - Drop enable argument of tja11xx_enable_l

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Andrew Lunn
On Sat, Dec 15, 2018 at 09:31:54AM -0800, Florian Fainelli wrote: > Le 12/15/18 à 9:01 AM, Andrew Lunn a écrit : > >> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { > >> + { "phy_symbol_error_count", 20, 0, 0x }, > >> + { "phy_overtemp_error", 21, 1, BIT(1) }, > >> + { "phy_undervol

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Heiner Kallweit
On 15.12.2018 18:01, Andrew Lunn wrote: >> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { >> +{ "phy_symbol_error_count", 20, 0, 0x }, >> +{ "phy_overtemp_error", 21, 1, BIT(1) }, >> +{ "phy_undervolt_error", 21, 3, BIT(3) }, >> +{ "phy_polarity_detect", 25, 6, BIT(6) }

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Florian Fainelli
Le 12/15/18 à 9:01 AM, Andrew Lunn a écrit : >> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { >> +{ "phy_symbol_error_count", 20, 0, 0x }, >> +{ "phy_overtemp_error", 21, 1, BIT(1) }, >> +{ "phy_undervolt_error", 21, 3, BIT(3) }, >> +{ "phy_polarity_detect", 25, 6, BIT

Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-15 Thread Andrew Lunn
> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = { > + { "phy_symbol_error_count", 20, 0, 0x }, > + { "phy_overtemp_error", 21, 1, BIT(1) }, > + { "phy_undervolt_error", 21, 3, BIT(3) }, > + { "phy_polarity_detect", 25, 6, BIT(6) }, > + { "phy_open_detect", 25, 7, BIT

[PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-14 Thread Marek Vasut
Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special BroadRReach 100BaseT1 PHYs used in automotive. Signed-off-by: Marek Vasut --- V2: - Use phy_modify(), phy_{set,clear}_bits() - Drop enable argument of tja11xx_enable_link_control() - Use PHY_BASIC_T1_FEATURES and dont