Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Shay Agroskin
David Miller writes: From: Saeed Mahameed Date: Thu, 17 Sep 2020 12:38:28 -0700 allocated but unregistered netdevices also do not help much as the name of the netdev is not assigned yet. why don't use dev_info(pci_dev) macors for low level functions when netdev is not available or not

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread David Miller
From: Saeed Mahameed Date: Thu, 17 Sep 2020 12:38:28 -0700 > allocated but unregistered netdevices also do not help much as the name > of the netdev is not assigned yet. > > why don't use dev_info(pci_dev) macors for low level functions when > netdev is not available or not allocated yet. The

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Saeed Mahameed
On Thu, 2020-09-17 at 21:45 +0300, Shay Agroskin wrote: > David Miller writes: > > > From: Shay Agroskin > > Date: Sun, 13 Sep 2020 11:16:34 +0300 > > > > > ENA logs are adjusted to display the full ENA representation to > > > distinct each ENA device in case of multiple interfaces. > > > Using

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-17 Thread Shay Agroskin
David Miller writes: From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using dev_err/warn/info function family for logging provides uniform printing with clear

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-14 Thread Shay Agroskin
David Miller writes: From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using dev_err/warn/info function family for logging provides uniform printing with clear

Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-13 Thread David Miller
From: Shay Agroskin Date: Sun, 13 Sep 2020 11:16:34 +0300 > ENA logs are adjusted to display the full ENA representation to > distinct each ENA device in case of multiple interfaces. > Using dev_err/warn/info function family for logging provides uniform > printing with clear distinction of the dr

[PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

2020-09-13 Thread Shay Agroskin
ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using dev_err/warn/info function family for logging provides uniform printing with clear distinction of the driver and device. This patch changes all printing in ena_com files t