Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Tue, Jul 21, 2020 at 4:55 AM Jason Wang wrote: > > > On 2020/7/20 下午7:16, Eugenio Pérez wrote: > > On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > >> On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > >>> On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/20 下午7:16, Eugenio Pérez wrote: On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Marti

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jul 20, 2020 at 10:55 AM Jason Wang wrote: > > > On 2020/7/17 上午1:16, Eugenio Perez Martin wrote: > > On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > >> On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > How about playing with the batch size? Make it

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jul 20, 2020 at 01:16:47PM +0200, Eugenio Pérez wrote: > > On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > > On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > > > On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin > > > wrote: > > > > On Fri, Jul 10, 2

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: > On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > > On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > > > On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > > > > > How about play

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: > On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > > > > On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > > > > How about playing with the batch size? Make it a mod parameter instead > > > > >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/17 上午1:16, Eugenio Perez Martin wrote: On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: How about playing with the batch size? Make it a mod parameter instead of the hard coded 64, and measure for all va

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: > > On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > > > How about playing with the batch size? Make it a mod parameter instead > > > > of the hard coded 64, and measure for all values 1 to 64 ... > > > > > > > > >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/10 下午1:39, Eugenio Perez Martin wrote: It is allocated 1 thread in lcore 1 (F_THREAD=1) which belongs to the same NUMA as testpmd. Actually, it is the testpmd master core, so it should be a good idea to move it to another lcore of the same NUMA node. Is this enough for pktgen to allo

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Martin wrote: > > > How about playing with the batch size? Make it a mod parameter instead > > > of the hard coded 64, and measure for all values 1 to 64 ... > > > > > > Right, according to the test result, 64 seems to be too aggressive in > >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Fri, Jul 10, 2020 at 5:56 AM Jason Wang wrote: > > > On 2020/7/10 上午1:37, Michael S. Tsirkin wrote: > > On Thu, Jul 09, 2020 at 06:46:13PM +0200, Eugenio Perez Martin wrote: > >> On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > >>> > >>> On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/10 上午1:37, Michael S. Tsirkin wrote: On Thu, Jul 09, 2020 at 06:46:13PM +0200, Eugenio Perez Martin wrote: On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: On 2020/7/1 下午6:43, Eugen

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Thu, Jul 09, 2020 at 06:46:13PM +0200, Eugenio Perez Martin wrote: > On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > > > > > > On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: > > > On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > > >> > > >> On 2020/7/1 下午6:43, Eugenio Perez Martin wrote:

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jul 1, 2020 at 4:10 PM Jason Wang wrote: > > > On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: > > On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > >> > >> On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: > >>> On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > >>> wrote: > On

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/1 下午9:04, Eugenio Perez Martin wrote: On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin wrote: On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: On Mon, Jun 22, 2020 at

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jul 1, 2020 at 2:40 PM Jason Wang wrote: > > > On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > > wrote: > >> On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > >>> On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jul 1, 2020 at 1:12 PM Michael S. Tsirkin wrote: > > On Wed, Jul 01, 2020 at 12:43:09PM +0200, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On M

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/7/1 下午6:43, Eugenio Perez Martin wrote: On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin wrote: On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wr

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jul 01, 2020 at 12:43:09PM +0200, Eugenio Perez Martin wrote: > On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin > wrote: > > > > On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > > > > On Mon,

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Tue, Jun 23, 2020 at 6:15 PM Eugenio Perez Martin wrote: > > On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, J

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jun 22, 2020 at 6:29 PM Michael S. Tsirkin wrote: > > On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > > > > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > > > > On Mon, Jun 1

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Tue, Jun 23, 2020 at 10:25 AM Michael S. Tsirkin wrote: > > On Tue, Jun 23, 2020 at 09:00:57AM +0200, Eugenio Perez Martin wrote: > > On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > > > > > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: > > > > On Wed, Jun 17, 2020 at 11:19:26AM +

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Tue, Jun 23, 2020 at 09:00:57AM +0200, Eugenio Perez Martin wrote: > On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: > > > On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: > > >> On 2020/6/11 下午7:34, Michael S. Tsirkin wro

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/6/23 下午3:00, Eugenio Perez Martin wrote: On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: static void vhost_vq_free_iovec

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Tue, Jun 23, 2020 at 4:51 AM Jason Wang wrote: > > > On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: > > On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: > >> On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: > >>>static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > >>>

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/6/23 上午12:00, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) { kfree(vq->descs); @@ -394,6 +400,9 @@ static long vhost_dev_a

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jun 22, 2020 at 06:11:21PM +0200, Eugenio Perez Martin wrote: > On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > > wrote: > > > > > > > > O

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jun 22, 2020 at 5:55 PM Michael S. Tsirkin wrote: > > On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > wrote: > > > > > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > > > wrote: > > > > > > > > O

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote: > > On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: > > static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > > { > > kfree(vq->descs); > > @@ -394,6 +400,9 @@ static long vhost_dev_alloc_iovecs(struct vhost_dev > > *dev)

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Fri, Jun 19, 2020 at 08:07:57PM +0200, Eugenio Perez Martin wrote: > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > wrote: > > > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > > wrote: > > > > > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > > > As

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jun 22, 2020 at 11:07 AM Jason Wang wrote: > > > On 2020/6/20 上午2:07, Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > > wrote: > >> On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > >> wrote: > >>> On Thu, Jun 11, 2020 at 07:34:19AM -0400, Mic

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/6/20 上午2:07, Eugenio Perez Martin wrote: On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin wrote: On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk wrote: On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: As testing shows no performance change, switch to th

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Fri, Jun 19, 2020 at 8:07 PM Eugenio Perez Martin wrote: > > On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin > wrote: > > > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > > wrote: > > > > > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > > > As testin

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Mon, Jun 15, 2020 at 2:28 PM Eugenio Perez Martin wrote: > > On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk > wrote: > > > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > > As testing shows no performance change, switch to that now. > > > > What kind of testing

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Wed, Jun 17, 2020 at 5:19 AM Jason Wang wrote: > > > On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: > > static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) > > { > > kfree(vq->descs); > > @@ -394,6 +400,9 @@ static long vhost_dev_alloc_iovecs(struct vhost_dev > > *dev) > >

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On 2020/6/11 下午7:34, Michael S. Tsirkin wrote: static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq) { kfree(vq->descs); @@ -394,6 +400,9 @@ static long vhost_dev_alloc_iovecs(struct vhost_dev *dev) for (i = 0; i < dev->nvqs; ++i) { vq = dev->vqs[i];

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Thu, Jun 11, 2020 at 5:22 PM Konrad Rzeszutek Wilk wrote: > > On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > > As testing shows no performance change, switch to that now. > > What kind of testing? 100GiB? Low latency? > Hi Konrad. I tested this version of the patch: htt

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

On Thu, Jun 11, 2020 at 07:34:19AM -0400, Michael S. Tsirkin wrote: > As testing shows no performance change, switch to that now. What kind of testing? 100GiB? Low latency?

[PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

As testing shows no performance change, switch to that now. Signed-off-by: Michael S. Tsirkin Signed-off-by: Eugenio Pérez Link: https://lore.kernel.org/r/20200401183118.8334-3-epere...@redhat.com Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- drivers/vhost/vhost.c | 314