Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Paolo Abeni
On Thu, 2019-09-19 at 15:37 +0300, Or Gerlitz wrote: > On Wed, Sep 18, 2019 at 2:48 PM Steffen Klassert > wrote: > > This patchset adds support to do GRO/GSO by chaining packets > > of the same flow at the SKB frag_list pointer. This avoids > > the overhead to merge payloads into one big packet, a

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Willem de Bruijn
On Thu, Sep 19, 2019 at 9:07 AM Marcelo Ricardo Leitner wrote: > > On Thu, Sep 19, 2019 at 08:55:22AM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > > On Wed

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Marcelo Ricardo Leitner
On Thu, Sep 19, 2019 at 11:41:06AM +0200, Steffen Klassert wrote: > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > wrote: > > > > > > This patchset adds support to do GRO/GSO by chaining packets > > > of the same flow at t

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Marcelo Ricardo Leitner
On Thu, Sep 19, 2019 at 08:55:22AM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > > wrote: > > > > > > > > This

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Willem de Bruijn
On Wed, Sep 18, 2019 at 12:58 PM Marcelo Ricardo Leitner wrote: > > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > > wrote: > > > > > > This patchset adds support to do GRO/GSO by chaining packets > > > of the same flow at

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Or Gerlitz
On Wed, Sep 18, 2019 at 2:48 PM Steffen Klassert wrote: > This patchset adds support to do GRO/GSO by chaining packets > of the same flow at the SKB frag_list pointer. This avoids > the overhead to merge payloads into one big packet, and > on the other end, if GSO is needed it avoids the overhead

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Thu, Sep 19, 2019 at 01:18:16PM +0200, David Miller wrote: > From: Steffen Klassert > Date: Thu, 19 Sep 2019 13:01:25 +0200 > > > If the packet data of all the fraglist GRO skbs are backed by a > > page fragment then we could just do the same by iterating with > > skb_walk_frags(). I'm not a d

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread David Miller
From: Steffen Klassert Date: Thu, 19 Sep 2019 13:01:25 +0200 > If the packet data of all the fraglist GRO skbs are backed by a > page fragment then we could just do the same by iterating with > skb_walk_frags(). I'm not a driver expert and might be misstaken, > but it looks like that could be don

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 01:58:17PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > > > > More specifically, whether we can remove that in favor of using your > > new skb_segment_list. That would actually be a big first step in > > simplif

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-19 Thread Steffen Klassert
On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > wrote: > > > > This patchset adds support to do GRO/GSO by chaining packets > > of the same flow at the SKB frag_list pointer. This avoids > > the overhead to merge payloads into

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-18 Thread Subash Abhinov Kasiviswanathan
On 2019-09-18 10:58, Marcelo Ricardo Leitner wrote: On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert wrote: > > This patchset adds support to do GRO/GSO by chaining packets > of the same flow at the SKB frag_list pointer. This av

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-18 Thread Marcelo Ricardo Leitner
On Wed, Sep 18, 2019 at 12:17:08PM -0400, Willem de Bruijn wrote: > On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert > wrote: > > > > This patchset adds support to do GRO/GSO by chaining packets > > of the same flow at the SKB frag_list pointer. This avoids > > the overhead to merge payloads into

Re: [PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-18 Thread Willem de Bruijn
On Wed, Sep 18, 2019 at 3:25 AM Steffen Klassert wrote: > > This patchset adds support to do GRO/GSO by chaining packets > of the same flow at the SKB frag_list pointer. This avoids > the overhead to merge payloads into one big packet, and > on the other end, if GSO is needed it avoids the overhea

[PATCH RFC v3 0/5] Support fraglist GRO/GSO

2019-09-18 Thread Steffen Klassert
This patchset adds support to do GRO/GSO by chaining packets of the same flow at the SKB frag_list pointer. This avoids the overhead to merge payloads into one big packet, and on the other end, if GSO is needed it avoids the overhead of splitting the big packet back to the native form. Patch 1 Ena