Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-14 Thread Martin KaFai Lau
On Thu, Aug 13, 2015 at 05:29:09PM -0700, David Miller wrote: > From: Martin KaFai Lau > Date: Thu, 13 Aug 2015 00:58:00 -0700 > > > This patch series fixes a potential deadlock when creating a pcpu rt. > > It happens when dst_alloc() decided to run gc. Something like this: > > > > read_lock(&ta

Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-14 Thread Steinar H. Gunderson
On Thu, Aug 13, 2015 at 12:58:00AM -0700, Martin KaFai Lau wrote: > Steinar, the patches can also be applied to 4.2-rc5 (I just tried). > Can you help to test them? Thanks! I won't be doing a boot in the near future (I want my server to be up, sorry :-) ), but if I _do_ have to boot, I'll be sure

Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-13 Thread David Miller
From: Martin KaFai Lau Date: Thu, 13 Aug 2015 00:58:00 -0700 > This patch series fixes a potential deadlock when creating a pcpu rt. > It happens when dst_alloc() decided to run gc. Something like this: > > read_lock(&table->tb6_lock); > ip6_rt_pcpu_alloc() > => dst_alloc() > => ip6_dst_gc() > =

[PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-13 Thread Martin KaFai Lau
This patch series fixes a potential deadlock when creating a pcpu rt. It happens when dst_alloc() decided to run gc. Something like this: read_lock(&table->tb6_lock); ip6_rt_pcpu_alloc() => dst_alloc() => ip6_dst_gc() => write_lock(&table->tb6_lock); /* oops */ Patch 1 and 2 are some prep works.