Re: [PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-13 Thread Kurt Kanzenbach
On Tue Apr 13 2021, Alexander Duyck wrote: > On Mon, Apr 12, 2021 at 7:29 AM Jesper Dangaard Brouer > wrote: >> > +ktime_t igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va) >> > { >> > struct igb_adapter *adapter = q_vector->adapter; >> > + struct skb_shared_hwtstamps ts; >>

Re: [PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-13 Thread Alexander Duyck
On Mon, Apr 12, 2021 at 7:29 AM Jesper Dangaard Brouer wrote: > > > On Mon, 12 Apr 2021 12:17:13 +0200 > Kurt Kanzenbach wrote: > > > When using native XDP with the igb driver, the XDP frame data doesn't point > > to > > the beginning of the packet. It's off by 16 bytes. Everything works as > >

Re: [PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-13 Thread Kurt Kanzenbach
On Mon Apr 12 2021, Jesper Dangaard Brouer wrote: > On Mon, 12 Apr 2021 12:17:13 +0200 > Kurt Kanzenbach wrote: > >> When using native XDP with the igb driver, the XDP frame data doesn't point >> to >> the beginning of the packet. It's off by 16 bytes. Everything works as >> expected >> with XDP

Re: [PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-12 Thread Jesper Dangaard Brouer
On Mon, 12 Apr 2021 12:17:13 +0200 Kurt Kanzenbach wrote: > When using native XDP with the igb driver, the XDP frame data doesn't point to > the beginning of the packet. It's off by 16 bytes. Everything works as > expected > with XDP skb mode. > > Actually these 16 bytes are used to store the

[PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-12 Thread Kurt Kanzenbach
When using native XDP with the igb driver, the XDP frame data doesn't point to the beginning of the packet. It's off by 16 bytes. Everything works as expected with XDP skb mode. Actually these 16 bytes are used to store the packet timestamps. Therefore, pull the timestamp before executing any XDP