Re: [PATCH RFC leds + net-next 4/7] leds: trigger: netdev: support HW offloading

2021-03-01 Thread Pavel Machek
Hi! > Add support for HW offloading of the netdev trigger. > > We need to change spinlock to mutex, because if spinlock is used, the > trigger_offload() method cannot sleep, which can happen for ethernet > PHYs. Is that bugfix or just needed for offloading? Should be separate patch in any case.

Re: [PATCH RFC leds + net-next 4/7] leds: trigger: netdev: support HW offloading

2020-11-05 Thread Marek Behún
On Fri, 30 Oct 2020 12:44:32 +0100 Marek Behún wrote: > + if (!led_trigger_offload(led_cdev)) > + return; > + The offload method has to read the settings, so this code (better: the whole set_baseline_state function) has to be always called with the mutex locked. (I am talking abo

[PATCH RFC leds + net-next 4/7] leds: trigger: netdev: support HW offloading

2020-10-30 Thread Marek Behún
Add support for HW offloading of the netdev trigger. We need to change spinlock to mutex, because if spinlock is used, the trigger_offload() method cannot sleep, which can happen for ethernet PHYs. We can change the spinlock to mutex because, according to Jacek: register_netdevice_notifier() re