Re: [PATCH RFC RFT net-next 03/10] net: dsa: mv88e6060: Replace REG_WRITE macro

2019-01-30 Thread Andrew Lunn
On Wed, Jan 30, 2019 at 10:24:51AM +0100, Pavel Machek wrote: > On Wed 2019-01-30 01:37:51, Andrew Lunn wrote: > > The REG_WRITE macro contains a return statement, making it not very > > safe. Remove it by inlining the code. > > Not bad, but maybe there should be dev_err() or something in case of

Re: [PATCH RFC RFT net-next 03/10] net: dsa: mv88e6060: Replace REG_WRITE macro

2019-01-30 Thread Pavel Machek
On Wed 2019-01-30 01:37:51, Andrew Lunn wrote: > The REG_WRITE macro contains a return statement, making it not very > safe. Remove it by inlining the code. Not bad, but maybe there should be dev_err() or something in case of reg_write() returns an error? Because no errors are expected in this ca

[PATCH RFC RFT net-next 03/10] net: dsa: mv88e6060: Replace REG_WRITE macro

2019-01-29 Thread Andrew Lunn
The REG_WRITE macro contains a return statement, making it not very safe. Remove it by inlining the code. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 73 + 1 file changed, 41 insertions(+), 32 deletions(-) diff --git a/drivers/net/dsa/mv88e60